Skip to content

Refactor git library#140

Merged
jessesuen merged 1 commit intoargoproj:masterfrom
jessesuen:git-refactor
Apr 30, 2018
Merged

Refactor git library#140
jessesuen merged 1 commit intoargoproj:masterfrom
jessesuen:git-refactor

Conversation

@jessesuen
Copy link
Member

@jessesuen jessesuen commented Apr 29, 2018 •
edited
Loading

@jessesuen
Refactor git library:
26a78bb 
* store credentials in files (instead of encoded in URL) to prevent leakage during git errors
* fix issue where HEAD would not track updates from origin/HEAD (resolves argoproj#133)
* refactor git library to promote code reuse, and remove shell invocations
@jessesuen jessesuen requested review from alexmt and merenbach April 29, 2018 09:57
@CLAassistant
Copy link

CLAassistant commented Apr 29, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jessesuen jessesuen merged commit fdf9515 into argoproj:master Apr 30, 2018
@jessesuen jessesuen deleted the git-refactor branch April 30, 2018 18:01
leoluz pushed a commit to leoluz/argo-cd that referenced this pull request Sep 29, 2023
@ash2k
refactor: Return error from context (argoproj#140)
8d05efd
@leoluz leoluz mentioned this pull request Mar 13, 2025
Closed
@leoluz leoluz mentioned this pull request Sep 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexmt alexmt alexmt approved these changes

+1 more reviewer

@merenbach merenbach merenbach approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

repo-server is not tracking HEAD properly An error when configuring a repo will expose git token in CLI output

4 participants

@jessesuen @CLAassistant @alexmt @merenbach