Persist parameters during deployment (Sync)#39
Merged
merenbach merged 33 commits intoargoproj:masterfrom Mar 16, 2018
merenbach:recent-deployments
Merged
Persist parameters during deployment (Sync)#39merenbach merged 33 commits intoargoproj:masterfrom merenbach:recent-deployments
merenbach merged 33 commits intoargoproj:masterfrom
merenbach:recent-deployments
Conversation
added 20 commits
March 15, 2018 14:57
alexmt
requested changes
Mar 16, 2018
Collaborator
alexmt
left a comment
alexmt
left a comment
There was a problem hiding this comment.
I've noticed that controller override whole status, instead of updating only comparison result:
https://github.com/argoproj/argo-cd/blob/master/controller/controller.go#L117
Can you please update controller? Otherwise it will remove deployment info field
server/application/application.go
Outdated
| } | ||
|
|
||
| // Persist app deployment info | ||
| app, err = s.Update(ctx, app) |
Collaborator
There was a problem hiding this comment.
Can you please set recent deployment only if actual deployment is successful?
added 9 commits
March 16, 2018 12:43
alexmt
approved these changes
Mar 16, 2018
Collaborator
alexmt
left a comment
alexmt
left a comment
There was a problem hiding this comment.
LGTM, please merge after checks pass
10 tasks
leoluz
pushed a commit
to leoluz/argo-cd
that referenced
this pull request
Sep 29, 2023
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This addresses the first subtask in issue #27.
Implementation