Issue #238 - add upsert flag to 'argocd app create' command#245
Issue #238 - add upsert flag to 'argocd app create' command#245alexmt merged 1 commit intoargoproj:masterfrom
Conversation
merenbach
left a comment
merenbach
left a comment
There was a problem hiding this comment.
@alexmt looks great! One minor question: earlier we added a feature to not complain on app create when the spec was the same. Since it now sounds as though that wasn't the desired behavior from stakeholders—instead, an upsert behavior, as implemented here, was desired—does it make sense to maybe remove the spec comparison and error out on app creation with the same name, as we used to, unless upsert is specified?
|
Spec comparison makes sense to me. I think it is convienient to notify user about spec difference unless |
|
@alexmt sounds good! |
| @@ -68,6 +69,13 @@ func (s *Server) List(ctx context.Context, q *ApplicationQuery) (*appv1.Applicat | |||
|
|
|||
| // Create creates an application | |||
| func (s *Server) Create(ctx context.Context, a *appv1.Application) (*appv1.Application, error) { | |||
There was a problem hiding this comment.
Should we just change the RPC signature to ApplicationCreateRequest instead of Application? Maybe not for 0.4.4 but for 0.5.0? Storing into context hides the API capabilities.
Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
3 participants
Closes: #238