Populated 'unexpected' resources while comparing target and live states#137
Merged
alexmt merged 3 commits intoargoproj:masterfrom Apr 27, 2018
Merged
Populated 'unexpected' resources while comparing target and live states#137alexmt merged 3 commits intoargoproj:masterfrom
alexmt merged 3 commits intoargoproj:masterfrom
Conversation
added 2 commits
April 27, 2018 09:41
…spoinding service
… target and live states
jessesuen
approved these changes
Apr 27, 2018
Member
jessesuen
left a comment
jessesuen
left a comment
There was a problem hiding this comment.
Just add some comments for each scenario why we decide something is OutOfSync.
| func isControlledBy(obj *unstructured.Unstructured, parent *unstructured.Unstructured) bool { | ||
| // TODO: remove special case after Service and Endpoint get explicit relationship ( https://github.com/kubernetes/kubernetes/issues/28483 ) | ||
| if obj.GetKind() == kubeutil.EndpointsKind && parent.GetKind() == kubeutil.ServiceKind { | ||
| return obj.GetName() == parent.GetName() |
|
|
||
| if targetObjs[i] == nil { | ||
| resState.TargetState = "null" | ||
| resState.Status = v1alpha1.ComparisonStatusOutOfSync |
Member
There was a problem hiding this comment.
I have no problems with the logic, but it takes some time to understand it. Can we add comments about each scenario and why we are considering it out of sync? For example:
- object is in target, but does not exist in live
- object is in target and live, but differ
- object is not defined in target, but exists in the live state
leoluz
pushed a commit
to leoluz/argo-cd
that referenced
this pull request
Sep 29, 2023
…oj#137) * fix: health status is set to healthy for statefulset with updateStrategy: OnDelete * fix: updated message * fix: added test * fix: health status for daemon set with Ondelete updateStrategy
sujeilyfonseca
pushed a commit
to sujeilyfonseca/argo-cd
that referenced
this pull request
Jun 7, 2024
sujeilyfonseca
pushed a commit
to sujeilyfonseca/argo-cd
that referenced
this pull request
Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #104