Split up CRD manifests into their own folder

[twz123]

This way, CRD and app deployments can be separated, e.g. if someone wishes to install Argo CD multiple times.

Also: Make update-manifests.sh fail-fast and more resilient against spaces in paths and user's CDPATH settings.

[jessesuen]

@twz123

1. we have a unit test TestGenerateYamlManifestInDir which is dependent on the number of manifests in the base directory. Can you just update the number from 22 to 20 to get the unit test to pass?

2. There is an e2e test which also depends on the location of the CRD manifests. in fixture.go, this would have to be updated:

func (f *Fixture) setup() error {
	_, err := exec.Command("kubectl", "apply", "-f", "../../manifests/base/application-crd.yaml", "-f", "../../manifests/base/appproject-crd.yaml").Output()

[twz123]

I fixed the tests. I must have missed the GitHub notification for this one, sorry!

[twz123]

Not sure whether this is a BSD vs GNU thing, but the previous version failed for me on Linux. Hope this works on OSX, too?

[jessesuen]

Just tried it -- it works on OS X, so you're good.

[jessesuen]

Oops I spoke too soon, I think we need to follow something like:
https://stackoverflow.com/questions/5694228/sed-in-place-flag-that-works-both-on-mac-bsd-and-linux

to support in-place editing that works on both linux and mac

[codecov-io]

Codecov Report

Merging #674 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #674   +/-   ##
=======================================
  Coverage   28.31%   28.31%           
=======================================
  Files          43       43           
  Lines        6630     6630           
=======================================
  Hits         1877     1877           
  Misses       4471     4471           
  Partials      282      282

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9347f41...eb5fb50. Read the comment docs.

[jessesuen]

Just tried it -- it works on OS X, so you're good.