Skip to content

Support helm charts with dependencies and namespace sensitivity (issue #582)#606

Merged
jessesuen merged 2 commits intoargoproj:masterfrom
jessesuen:582-helm-dep-update
Sep 17, 2018
Merged

Support helm charts with dependencies and namespace sensitivity (issue #582)#606
jessesuen merged 2 commits intoargoproj:masterfrom
jessesuen:582-helm-dep-update

Conversation

@jessesuen
Copy link
Member

  • Run helm dep build before helm template to download a chart's dependencies. This allows charts with dependencies to be deployed (e.g. spinnaker, wordpress).
  • Update the manifest for argocd-repo-server such that it runs without a service account token. This was done because helm was inferring the current namespace from this token, and the argocd namespace would be exposed in the chart's manifests. By removing the token, helm will use the namespace "default" in the manifests (when needed)
  • Add a TCP readiness probe to argocd-repo-server (issue Add readiness probe to repo server #529)
  • Some helm charts (e.g. spinnaker) are sensitive to the value of helm template --namespace NAMESPACE, because it incorporates the namespace into the manifests. To support these type of charts, a new namespace field was added to ManifestRequest so that these helm charts can be deployed with ArgoCD.
  • Fix issue where helm hooks were being deployed as part of sync (issue Helm hooks are being deployed as resources #605)

@jessesuen jessesuen force-pushed the 582-helm-dep-update branch 2 times, most recently from d236f79 to 4cc3cc6 Compare September 15, 2018 09:20
@jessesuen jessesuen merged commit bfb558e into argoproj:master Sep 17, 2018
leoluz pushed a commit to leoluz/argo-cd that referenced this pull request Mar 13, 2025
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants