Issue #280 - It is impossible to restrict application access by repository URL#281
Merged
alexmt merged 2 commits intoargoproj:masterfrom Jun 12, 2018
Merged
Issue #280 - It is impossible to restrict application access by repository URL#281alexmt merged 2 commits intoargoproj:masterfrom
alexmt merged 2 commits intoargoproj:masterfrom
Conversation
alexmt
changed the title
…by repository URL
merenbach
approved these changes
Jun 12, 2018
Contributor
merenbach
left a comment
merenbach
left a comment
There was a problem hiding this comment.
One minor thought. Good work!
server/application/application.go
Outdated
|
|
||
| // appRBACName formats fully qualified application name for RBAC check | ||
| func appRBACName(app appv1.Application) string { | ||
| return fmt.Sprintf("%s/%s", git.NormalizeGitURL(app.Spec.Source.RepoURL), app.Name) |
Contributor
There was a problem hiding this comment.
Wonder if return path.Join(git.NormalizeGitURL(app.Spec.Source.RepoURL), app.Name) might be just slightly more semantically appropriate.
Collaborator
Author
There was a problem hiding this comment.
done. thank you for suggestion!
leoluz
pushed a commit
to leoluz/argo-cd
that referenced
this pull request
Sep 29, 2023
…argoproj#281) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.