Switch to go-git for all remote git interactions including auth (issue #651)#652
Merged
jessesuen merged 2 commits intoargoproj:masterfrom Sep 27, 2018
Merged
Conversation
7266680 to
1fce765
Compare
merenbach
approved these changes
Sep 27, 2018
Contributor
merenbach
left a comment
There was a problem hiding this comment.
Looks good! Just out of curiosity, what does the line where we're setting HOME=/dev/null in the checkout command environment do?
alexmt
approved these changes
Sep 27, 2018
Member
Author
it makes dev environment closer to the actual environment by not picking up gitconfigs in user's home directory. |
leoluz
pushed a commit
to leoluz/argo-cd
that referenced
this pull request
Mar 13, 2025
Fixes issue that showed up in argoproj/gitops-engine#650 [Error](https://github.com/argoproj/gitops-engine/actions/runs/12300709584/job/34329534904?pr=650#step:5:96) Signed-off-by: jmeridth <jmeridth@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches all interactions with a git remote to use go-git (instead of git CLI) which provides the following benefits:
Also fixes an issue where argocd-server logged credentials in plain text during repo add (issue #653)
Performed the following tests: