Skip to content

Switch to go-git for all remote git interactions including auth (issue #651)#652

Merged
jessesuen merged 2 commits intoargoproj:masterfrom
jessesuen:651-go-git-auth
Sep 27, 2018
Merged

Switch to go-git for all remote git interactions including auth (issue #651)#652
jessesuen merged 2 commits intoargoproj:masterfrom
jessesuen:651-go-git-auth

Conversation

@jessesuen
Copy link
Copy Markdown
Member

@jessesuen jessesuen commented Sep 27, 2018

Switches all interactions with a git remote to use go-git (instead of git CLI) which provides the following benefits:

  • resolves issue Credentials not being accepted for Google Source Repositories #651 where Google Source Repository credentials were not being accepted
  • we never store credentials on disk in the repo server (or anywhere else for that matter)
  • eliminates the extra git process forks we currently perform with respect to managing credentials

Also fixes an issue where argocd-server logged credentials in plain text during repo add (issue #653)

Performed the following tests:

  • private credentials to GSR
  • git with SSH private key
  • public repos
  • verified updates to HEAD, branch, and git tags were seen

Copy link
Copy Markdown
Contributor

@merenbach merenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just out of curiosity, what does the line where we're setting HOME=/dev/null in the checkout command environment do?

@jessesuen
Copy link
Copy Markdown
Member Author

Looks good! Just out of curiosity, what does the line where we're setting HOME=/dev/null in the checkout command environment do?

it makes dev environment closer to the actual environment by not picking up gitconfigs in user's home directory.

@jessesuen jessesuen merged commit 316fcc6 into argoproj:master Sep 27, 2018
leoluz pushed a commit to leoluz/argo-cd that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants