Skip to content

Retry sync and rollback#347

Merged
merenbach merged 16 commits intoargoproj:masterfrom
merenbach:retry-sync-and-rollback
Jul 3, 2018
Merged

Retry sync and rollback#347
merenbach merged 16 commits intoargoproj:masterfrom
merenbach:retry-sync-and-rollback

Conversation

@merenbach
Copy link
Contributor

Closes #323

@merenbach merenbach requested a review from jessesuen July 3, 2018 17:23
@jessesuen
Copy link
Member

I think you may have misinterpreted the issue. I don't think we should be adding wait functionality to the sync and rollback commands. Issue #323 is really about how app sync cannot tolerate any connection resets from the API server, whereas app wait can. There is a helper function that enables re-establishing the connection, but that helper is not used in app sync.

@merenbach
Copy link
Contributor Author

@jessesuen have now updated with suggested changes

@merenbach merenbach merged commit c2fde1d into argoproj:master Jul 3, 2018
@merenbach merenbach deleted the retry-sync-and-rollback branch July 3, 2018 22:47
leoluz pushed a commit to leoluz/argo-cd that referenced this pull request Sep 29, 2023
…#347)

Signed-off-by: Roman Rudenko <3kmnazapad@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants