Clean up .proto definitions for consistency and reduction of pointer usage#253
Merged
jessesuen merged 1 commit intoargoproj:masterfrom Jun 1, 2018
Merged
Conversation
Member
jessesuen
commented
May 31, 2018
jessesuen
commented
- Rename {applicationName} and {appName} to {name}
- Remove unecessary UpdateREST endpoints
- Prefix some requests/queries with Application
merenbach
approved these changes
May 31, 2018
Contributor
merenbach
left a comment
merenbach
left a comment
There was a problem hiding this comment.
Exciting cleanup! Good work.
Member
Author
|
Failure is due to some mockery stuff. will fix. |
leoluz
pushed a commit
to leoluz/argo-cd
that referenced
this pull request
Sep 29, 2023
Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.