Skip to content

Support adding name prefix in helm and kustomize#735

Merged
dthomson25 merged 1 commit intoargoproj:masterfrom
dthomson25:add-prefix
Oct 29, 2018
Merged

Support adding name prefix in helm and kustomize#735
dthomson25 merged 1 commit intoargoproj:masterfrom
dthomson25:add-prefix

Conversation

@dthomson25
Copy link
Member

Fixes #721

@dthomson25 dthomson25 requested a review from jessesuen October 29, 2018 21:00
pStr, _ := json.Marshal(q.ComponentParameterOverrides)
valuesFiles := strings.Join(q.ValueFiles, ",")
return fmt.Sprintf("mfst|%s|%s|%s|%s|%s|%s|%s", q.AppLabel, q.Path, q.Environment, commitSHA, string(pStr), valuesFiles, q.Namespace)
return fmt.Sprintf("mfst|%s|%s|%s|%s|%s|%s|%s|%s", q.AppLabel, q.Path, q.Environment, commitSHA, string(pStr), valuesFiles, q.Namespace, q.NamePrefix)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you thought about this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dthomson25 dthomson25 merged commit 2c8c2fc into argoproj:master Oct 29, 2018
@dthomson25 dthomson25 deleted the add-prefix branch October 29, 2018 23:05
ppapapetrou76 pushed a commit to ppapapetrou76/argo-cd that referenced this pull request Aug 19, 2025
* upgrade k8s to 1.33.1

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* fix linter issues

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

---------

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants