Issue # 223 - Remove app finalizers during e2e fixture teardown

[alexmt]

Closes #223

[merenbach]

Looks good to me. One tiny comment.

[merenbach]

Wondering if this could be moved right after line 206, thus obviating the need for sequential inverse conditionals.

[alexmt]

Logic would change if I move it.

TearDown method is checking if the previous operation successful and trying to delete namespace. Delete operation error is stored same err variable. Finally method checking if err is not nil which means something went wrong and report that teardown had issues. I hope I'm not missing something obvious.

[merenbach]

Ah, yes, my mistake! Good work!

…

On Tue, May 22, 2018 at 9:16 AM, Alexander Matyushentsev < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In test/e2e/fixture.go <#225 (comment)>: > + patch, err = json.Marshal(map[string]interface{}{ + "metadata": map[string]interface{}{ + "finalizers": make([]string, 0), + }, + }) + if err == nil { + _, err = f.AppClient.ArgoprojV1alpha1().Applications(app.Namespace).Patch(app.Name, types.MergePatchType, patch) + } + } + if err != nil { + break + } + } + } + if err == nil { + err = f.KubeClient.CoreV1().Namespaces().Delete(f.Namespace, &metav1.DeleteOptions{}) Logic would change if I move it. TearDown method is checking if the previous operation successful and trying to delete namespace. Delete operation error is stored same err variable. Finally method checking if err is not nil which means something went wrong and report that teardown had issues. I hope I'm not missing something obvious. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#225 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABFZ1GGFxgO99EqjDQAHolVA-e4HFIO9ks5t1DnRgaJpZM4UI7lg> .