Add GitHub webhook handling to fast-track controller application reprocessing#160
Merged
jessesuen merged 2 commits intoargoproj:masterfrom May 5, 2018
Merged
Add GitHub webhook handling to fast-track controller application reprocessing#160jessesuen merged 2 commits intoargoproj:masterfrom
jessesuen merged 2 commits intoargoproj:masterfrom
Conversation
Member
Author
|
NOTE: I will be working on clean up and adding unit tests, but wanted to get the review started. I did end-to-end testing by pushing to a github test repo configured with a webhook pointing to my API server (over ngrok) |
merenbach
approved these changes
May 4, 2018
alexmt
approved these changes
May 4, 2018
jessesuen
force-pushed
the
webhook
branch
2 times, most recently
from
409abb3 to
1509629
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves issue #121.
An new endpoint in the API server
/api/webhookis introduced, which receives a GitHub Push Event. Upon receipt, it queries all applications, and matches any that are of the same repo and revision. If the application matches, it sets an annotation in the application (with current timestamp) so that the controller is woken up for reprocessing of the app. Special logic exists to handle the case where the target is HEAD.