Skip to content

Fix production swagger#403

Merged
merenbach merged 4 commits intoargoproj:masterfrom
merenbach:fix-production-swagger
Jul 13, 2018
Merged

Fix production swagger#403
merenbach merged 4 commits intoargoproj:masterfrom
merenbach:fix-production-swagger

Conversation

@merenbach
Copy link
Contributor

Close #399

@merenbach merenbach requested a review from jessesuen July 13, 2018 16:05
Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks fine but please fix build issue before merging

@merenbach
Copy link
Contributor Author

@jessesuen thanks! I was talking to @alexmt about this. It seems that the error is because of the code I have to use to get from the util/swagger/ directory to the server/ directory:

box := packr.NewBox(path.Join("..", "..", component))

The error is:

2018/07/13 16:11:08 stat /go/src/github.com/server/swagger.json: no such file or directory

It seems to be omitting the argoproj/argo-cd, likely because of the double .. in the original line. Trying to figure out how to have our cake and eat it, too.

@merenbach merenbach merged commit 7e0cd01 into argoproj:master Jul 13, 2018
@merenbach merenbach deleted the fix-production-swagger branch July 13, 2018 18:11
leoluz pushed a commit to leoluz/argo-cd that referenced this pull request Sep 29, 2023
* chore: test resource conversion

Signed-off-by: Michael Crenshaw <michael_crenshaw@intuit.com>

* chore: add const to avoid code smell

Signed-off-by: Michael Crenshaw <michael_crenshaw@intuit.com>

Co-authored-by: Michael Crenshaw <michael_crenshaw@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants