Issue #136 - Use custom formatter to get desired state of deployment and service#145
Merged
alexmt merged 2 commits intoargoproj:masterfrom Apr 30, 2018
Merged
Conversation
…loyment and service
jessesuen
approved these changes
Apr 30, 2018
util/ksonnet/ksonnet.go
Outdated
| switch obj.GetAPIVersion() + ":" + obj.GetKind() { | ||
| case "apps/v1beta1:Deployment": | ||
| newObj = &v1beta1.Deployment{} | ||
| break |
Member
There was a problem hiding this comment.
Style nit: in go, you don't need to stay break after each case.
| if err != nil { | ||
| return err | ||
| } | ||
| obj.Object = diff.RemoveMapFields(oldObj, obj.Object) |
Member
There was a problem hiding this comment.
Please document the reason for all the back and forth marshaling/unmarshalling going on here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #132
Closes #136