Skip to content

chore: copy gitops-engine deps to test container#24764

Merged
blakepettersson merged 1 commit intoargoproj:masterfrom
fm1ck3y:fix/test-container
Sep 28, 2025
Merged

chore: copy gitops-engine deps to test container#24764
blakepettersson merged 1 commit intoargoproj:masterfrom
fm1ck3y:fix/test-container

Conversation

@fm1ck3y
Copy link
Contributor

@fm1ck3y fm1ck3y commented Sep 28, 2025

refs: #24710

Changed made:

  • fix building test container with gitops-engine local dep

Execution command: make test
Output:

9.015 go: cannot load module gitops-engine listed in go.work file: open gitops-engine/go.mod: no such file or directory
9.016 + module=
------
Dockerfile:59
--------------------
  58 |
  59 | >>> RUN ./install.sh helm && \
  60 | >>>     ./install.sh kustomize && \
  61 | >>>     ./install.sh codegen-tools && \
  62 | >>>     ./install.sh codegen-go-tools && \
  63 | >>>     ./install.sh lint-tools && \
  64 | >>>     ./install.sh gotestsum && \
  65 | >>>     go install github.com/mattn/goreman@latest && \
  66 | >>>     go install github.com/kisielk/godepgraph@latest && \
  67 | >>>     go install github.com/jstemmer/go-junit-report@latest && \
  68 | >>>     rm -rf /tmp/dl && \
  69 | >>>     rm -rf /tmp/helm && \
  70 | >>>     rm -rf /tmp/ks_*
  71 |
--------------------
ERROR: failed to solve: process "/bin/sh -c ./install.sh helm &&     ./install.sh kustomize &&     ./install.sh codegen-tools &&     ./install.sh codegen-go-tools &&     ./install.sh lint-tools &&     ./install.sh gotestsum &&     go install github.com/mattn/goreman@latest &&     go install github.com/kisielk/godepgraph@latest &&     go install github.com/jstemmer/go-junit-report@latest &&     rm -rf /tmp/dl &&     rm -rf /tmp/helm &&     rm -rf /tmp/ks_*" did not complete successfully: exit code: 1

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Artem Vdovin <arte.vdovin@gmail.com>
@fm1ck3y fm1ck3y requested a review from a team as a code owner September 28, 2025 05:50
@bunnyshell
Copy link

bunnyshell bot commented Sep 28, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@fm1ck3y fm1ck3y changed the title fix: copy gitops-engine deps to test container chore: copy gitops-engine deps to test container Sep 28, 2025
@codecov
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.65%. Comparing base (af7ae18) to head (b90955a).
⚠️ Report is 398 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #24764      +/-   ##
==========================================
- Coverage   60.66%   60.65%   -0.02%     
==========================================
  Files         404      404              
  Lines       66092    66092              
==========================================
- Hits        40095    40085      -10     
- Misses      22737    22749      +12     
+ Partials     3260     3258       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blakepettersson blakepettersson merged commit d00c99d into argoproj:master Sep 28, 2025
42 of 44 checks passed
@blakepettersson
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants