Derive dedicated Dex deployment#564
Derive dedicated Dex deployment#564merenbach merged 22 commits intoargoproj:masterfrom merenbach:555-dedicated-dex-deployment
Conversation
Go through the steps of configure SSO for your minikube environment: |
There was a problem hiding this comment.
dex don't talk to kubernetes, so we can remove serviceAccountName.
There was a problem hiding this comment.
please disregard this comment. we need to launch /shared/argocd-util which reads configmaps, so we need separate service account, role and binding.
There was a problem hiding this comment.
copyutil init container is not needed for dex
There was a problem hiding this comment.
please disregard this comment. we need both volume and init container
There was a problem hiding this comment.
volume is not required for dex
There was a problem hiding this comment.
please disregard this comment. we need both volume and init container
|
A code change is needed to update the reverse proxy to point to the new dex hostname. Which means you need a service object for dex (in addition to the deployment). |
|
@jessesuen decided it would be over-engineering to bring in my other code. :p Just rewrote the token generation instead. |
|
LGTM |
There was a problem hiding this comment.
We do not want this role to read all secrets and configmaps in the namespace just the settings one. We should add:
resourceNames:
- argocd-cm
- argocd-secret
|
For posterity, here's testing instructions:
|
…idation even with server side apply (argoproj#564) * Revert "feat: retry with client side dry run if server one was failed (argoproj#548)" This reverts commit c0c2dd1. Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Revert "fix(server): use server side dry run in case if it is server side apply (argoproj#546)" This reverts commit 4a5648e. Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Fixed the logic to disable server side apply if it is a dry run Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Added more values in the log message for better debugging Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Fixed compilation error Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Written an inline fn to get string value of dry-run strategy Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Added comment as requested with reference to the issue number Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> --------- Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> Co-authored-by: Leonardo Luz Almeida <leoluz@users.noreply.github.com>
Dutifully closes #555.
Help wanted: how to test properly? I can see that the local Dex container gets created.Testing in progress.Also updates pseudo-random token generation for SSO to be more cryptographically secure.