Allow more fine-grained sync (#508)#666
Merged
merenbach merged 31 commits intoargoproj:masterfrom Oct 10, 2018
merenbach:508-sync-single-resource
Merged
Allow more fine-grained sync (#508)#666merenbach merged 31 commits intoargoproj:masterfrom merenbach:508-sync-single-resource
merenbach merged 31 commits intoargoproj:masterfrom
merenbach:508-sync-single-resource
Conversation
merenbach
added
help-wanted
merenbach
changed the title
alexmt
requested changes
Oct 8, 2018
controller/sync.go
Outdated
Collaborator
There was a problem hiding this comment.
Both liveObj or targetObj might be null. Check should be
sc.syncResources == nil || argo.ContainsSyncResource(liveObj, sc.syncResources) || argo.ContainsSyncResource(targetObj, sc.syncResources)
added 23 commits
October 9, 2018 09:22
This reverts commit b382bc882d2cd79ef4deb006c781282bef844d30.
added 8 commits
October 9, 2018 09:22
alexmt
approved these changes
Oct 10, 2018
leoluz
pushed a commit
to leoluz/argo-cd
that referenced
this pull request
Mar 13, 2025
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
leoluz
pushed a commit
to leoluz/argo-cd
that referenced
this pull request
Mar 13, 2025
…rgoproj#662) * fix: New kube applier for server side diff dry run with refactoring Part of a fix for: argoproj#21488 Separate logic to handle server side diff dry run applies. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Break backwards compatibility for a better code Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Don't put applier constructor in the interface Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Address comments Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Address more comments Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * chore: enable testifylint linter (argoproj#657) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * chore: enable gofumpt, gosimple and whitespace linters (argoproj#666) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * chore: enable use-any from revive (argoproj#667) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * chore: bump golangci-lint to v1.63.4 and list argo-cd linters (argoproj#670) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * chore: enable unused-parameter and var-declaration from revive (argoproj#668) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * chore: remove actions/cache duplicated behavior with actions/setup-go (argoproj#658) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Add Leo's code Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Make linter happy Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Co-authored-by: Matthieu MOREL <matthieu.morel35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
In #262, we added the ability to delete individual resources. Now, per #508, we'd like to extend this to sync the same. This PR closes #508. WIP. Please do not merge yet.
Use like this:
This hangs a K8s cluster—may be a bug (thanks @alexmt):
./dist/argocd app sync ks-guestbook --resource :Deployment:ks-guestbook-uiTodo