Run all containers as an unprivileged user (resolves #528)#546
Merged
jessesuen merged 1 commit intoargoproj:masterfrom Sep 4, 2018
Merged
Run all containers as an unprivileged user (resolves #528)#546jessesuen merged 1 commit intoargoproj:masterfrom
jessesuen merged 1 commit intoargoproj:masterfrom
Conversation
merenbach
approved these changes
Sep 1, 2018
leoluz
pushed a commit
to leoluz/argo-cd
that referenced
this pull request
Mar 13, 2025
…ly (argoproj#546) * fix: use server side dry run in case if it is server side apply Signed-off-by: pashakostohrys <pavel@codefresh.io> * fix: use server side dry run in case if it is server side apply Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io>
leoluz
added a commit
to leoluz/argo-cd
that referenced
this pull request
Mar 13, 2025
…idation even with server side apply (argoproj#564) * Revert "feat: retry with client side dry run if server one was failed (argoproj#548)" This reverts commit c0c2dd1. Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Revert "fix(server): use server side dry run in case if it is server side apply (argoproj#546)" This reverts commit 4a5648e. Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Fixed the logic to disable server side apply if it is a dry run Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Added more values in the log message for better debugging Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Fixed compilation error Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Written an inline fn to get string value of dry-run strategy Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Added comment as requested with reference to the issue number Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> --------- Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> Co-authored-by: Leonardo Luz Almeida <leoluz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.