Merged
Conversation
merenbach
approved these changes
Sep 28, 2018
Contributor
merenbach
left a comment
merenbach
left a comment
There was a problem hiding this comment.
Looks good! Should we include anything about supporting external Ksonnet (and upgrading the Dockerfile to Ksonnet 0.13.0), or is that excluded from this version?
Collaborator
Author
|
Ksonnet changes are not included into v0.9.2 |
leoluz
pushed a commit
to leoluz/argo-cd
that referenced
this pull request
Mar 13, 2025
…rgoproj#662) * fix: New kube applier for server side diff dry run with refactoring Part of a fix for: argoproj#21488 Separate logic to handle server side diff dry run applies. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Break backwards compatibility for a better code Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Don't put applier constructor in the interface Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Address comments Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Address more comments Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * chore: enable testifylint linter (argoproj#657) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * chore: enable gofumpt, gosimple and whitespace linters (argoproj#666) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * chore: enable use-any from revive (argoproj#667) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * chore: bump golangci-lint to v1.63.4 and list argo-cd linters (argoproj#670) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * chore: enable unused-parameter and var-declaration from revive (argoproj#668) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * chore: remove actions/cache duplicated behavior with actions/setup-go (argoproj#658) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Add Leo's code Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> * Make linter happy Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> --------- Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Co-authored-by: Matthieu MOREL <matthieu.morel35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.