Add iat as path param for delete token http call#586
Merged
dthomson25 merged 1 commit intoargoproj:masterfrom Sep 13, 2018
Merged
Add iat as path param for delete token http call#586dthomson25 merged 1 commit intoargoproj:masterfrom
dthomson25 merged 1 commit intoargoproj:masterfrom
Conversation
jessesuen
approved these changes
Sep 13, 2018
Member
|
BTW, PR title is wrong: you actually added a path param and not a query param. |
dthomson25
changed the title
leoluz
pushed a commit
to leoluz/argo-cd
that referenced
this pull request
Mar 13, 2025
* chore(deps): bump k8s libs from 0.29.2 to 0.29.6 Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * oops Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the http delete token call by adding the iat to the path. Without the fix, the http call has no means to set the iat variable. Since that variable is the ID used to identity the JWT token, the server can't identify which token to delete.