TLS support. HTTP/HTTPS/gRPC all serving on single port by jessesuen · Pull Request #78 · argoproj/argo-cd

jessesuen · 2018-04-07T01:07:08Z

This generates a self-signed certificate during install and stores it in the argocd-secret. The server will run with HTTP/HTTPS/gRPC all serving on port 8080.

TODO:

The HTTP handler should do a 302 redirect to HTTPS
copy the cert to the users home .argocd directory so that argocd CLI can use it

wanghong230 · 2018-04-09T17:54:57Z

install/install.go

Should we support the user provided certificate? User may have a CA certified certificate for using. I am assuming that we will hit this use case very soon.

Yes, this can be an install option. Will address it in future checkin.

wanghong230 · 2018-04-09T18:09:10Z

server/server.go

Will we expose the http to outside since https seems to be always there?

We should not serve any content when running in HTTP mode (and TLS is enabled). I still need to implement a 302 redirect handler if the connection muxes to HTTP.

Rename 'resources tree' to 'resource tree'

…j#78) Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 0.0.5 to 0.0.7. - [Release notes](https://github.com/spf13/cobra/releases) - [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md) - [Commits](spf13/cobra@0.0.5...0.0.7) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: disable dependabot Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: user server side filtering & pagination to load Argo CD applications list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix cluster filtering and refresh button on application list page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: api server fails with "nil pointer dereference" error (argoproj#40) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): ui should show the same page number as in API (argoproj#38) * feat: repository/Service.ListRefs returns raw list of refs (argoproj#42) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat(multi-cluster k8s dashboard): Make necessary changes for multi-cluster k8s dashboard feature in AKP (argoproj#48) * feat: send data to agent Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * (wip)feat: send data to syncer APIs * add support for columns info * fix: resource deletion missing events * feat: use resource sync and health info * chore: disable dependabot Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: user server side filtering & pagination to load Argo CD applications list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix cluster filtering and refresh button on application list page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: api server fails with "nil pointer dereference" error (argoproj#40) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): ui should show the same page number as in API (argoproj#38) * feat: repository/Service.ListRefs returns raw list of refs (argoproj#42) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): Reoreding filters (argoproj#44) * fix(ui): Reoreding filters * fix * fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: enable dashboard feature by using env var * fix: 1.21.0 -> 1.21 * chore: disable dependabot Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: user server side filtering & pagination to load Argo CD applications list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix cluster filtering and refresh button on application list page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: api server fails with "nil pointer dereference" error (argoproj#40) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): ui should show the same page number as in API (argoproj#38) * feat: repository/Service.ListRefs returns raw list of refs (argoproj#42) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): Reoreding filters (argoproj#44) * fix(ui): Reoreding filters * fix * fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Mayursinh Sarvaiya <marvinduff97@gmail.com> Co-authored-by: Rafal <rafpelczar@gmail.com> * fix: using http client with timeout (argoproj#51) * feat: send api resource count and object count from argocd application controller (argoproj#52) * feat: add destination metadata for argocd UI repo calls (argoproj#53) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * fix: argocd only send cluster info once (argoproj#54) * send all health statuses (argoproj#55) * feat: added commit abilities to reposerver (argoproj#56) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * chore: use FedRAMP compliant binaries (argoproj#57) Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com> * feat: implement resource filtering in app source and app filtering in appset (argoproj#58) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: helm binary path in image (argoproj#59) * fix: application set should not attempt to talk to managed cluster (argoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): Application stats flickers (argoproj#61) * feat: add cluster scoped for kubevision resource info (argoproj#62) * add namespaced * use cluster scoped * use v5 * fix: api server uses invalid matching while checking app namespace (argoproj#63) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: Undefined in Argo CD apps search box and app-in-any-namespace enabled (argoproj#64) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: support reading notifications settings from a different k8s (argoproj#66) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: add akuity-release-cli (argoproj#67) * feat: add akuity-release-cli Signed-off-by: Justin Marquis <justin@akuity.io> * go mod tidy Signed-off-by: Justin Marquis <justin@akuity.io> --------- Signed-off-by: Justin Marquis <justin@akuity.io> * fix: akuity-release-cli (argoproj#68) Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * add skipOnFailure flag to appset filters (argoproj#69) * fix(appset): improve git generator repo credential fallback (argoproj#21167) * fix: read settings from host namespace instead of control plane namespace (argoproj#70) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: add support for deleting files/dir in repo server (argoproj#71) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: store original URL in global variable (argoproj#72) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: argocd app controller should not be affected when syncer is down (argoproj#73) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: handle delegated appset generate cli calls (argoproj#74) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * refactor: local generate condition (argoproj#75) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: ensure appset generate call also filters the apps (argoproj#76) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: appset generator cannot access app metadata (argoproj#77) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: circular dependency error Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix sync status missing (argoproj#78) * feat: favorite application filter (argoproj#79) * feat: favorite filter * feat: test * fix: ap.pb.go * fix: application-list * fix: remove duplicate * fix: proto * fix: pagination for fav * remove: debug logs Signed-off-by: bhavyabhut <pbhavy4@gmail.com> --------- Signed-off-by: bhavyabhut <pbhavy4@gmail.com> * feat: add replace handler to power dashboard (argoproj#82) Co-authored-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com> * handle only when repo-server delegated * fix typo * cache redis clients Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com> Signed-off-by: Justin Marquis <justin@akuity.io> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: bhavyabhut <pbhavy4@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Mayursinh Sarvaiya <marvinduff97@gmail.com> Co-authored-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com> Co-authored-by: Rafal <rafpelczar@gmail.com> Co-authored-by: Soumya Ghosh Dastidar <44349253+gdsoumya@users.noreply.github.com> Co-authored-by: Xiaopeng Han <hanxiaop8@outlook.com> Co-authored-by: Anubhav Gupta <mail.anubhav06@gmail.com> Co-authored-by: Rafal <rafal@akuity.io> Co-authored-by: Yiwei Gong <imwithye@gmail.com> Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com> Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Bhavya Bhut <pbhavy4@gmail.com>

jessesuen requested review from alexmt, merenbach and wanghong230 April 7, 2018 01:07

alexmt approved these changes Apr 9, 2018

View reviewed changes

wanghong230 reviewed Apr 9, 2018

View reviewed changes

merenbach approved these changes Apr 9, 2018

View reviewed changes

jessesuen force-pushed the tls branch 3 times, most recently from cfe14eb to 409f152 Compare April 9, 2018 23:23

TLS support. HTTP/HTTPS/gRPC all serving on single port

880dc6f

jessesuen force-pushed the tls branch from 409f152 to 880dc6f Compare April 9, 2018 23:28

jessesuen merged commit 7e47b1e into argoproj:master Apr 9, 2018

jessesuen deleted the tls branch September 17, 2018 21:15

alexec pushed a commit that referenced this pull request Apr 24, 2019

Rename 'controlled resources' to 'managed resources' (#78)

c48b9f8

Rename 'resources tree' to 'resource tree'

leoluz mentioned this pull request Mar 13, 2025

chore: incorporate gitops-engine lib preserving history #22341

Closed

leoluz mentioned this pull request Sep 23, 2025

chore: gitops-engine migration #24710

Merged

alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Nov 20, 2025

fix sync status missing (argoproj#78)

7d51703

alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Jan 13, 2026

fix sync status missing (argoproj#78)

e4d5bdb

alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Mar 21, 2026

fix sync status missing (argoproj#78)

4332ba2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TLS support. HTTP/HTTPS/gRPC all serving on single port#78

TLS support. HTTP/HTTPS/gRPC all serving on single port#78
jessesuen merged 1 commit intoargoproj:masterfrom
jessesuen:tls

jessesuen commented Apr 7, 2018

Uh oh!

wanghong230 Apr 9, 2018

Uh oh!

jessesuen Apr 9, 2018

Uh oh!

wanghong230 Apr 9, 2018

Uh oh!

jessesuen Apr 9, 2018 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jessesuen commented Apr 7, 2018

Uh oh!

wanghong230 Apr 9, 2018

Choose a reason for hiding this comment

Uh oh!

jessesuen Apr 9, 2018

Choose a reason for hiding this comment

Uh oh!

wanghong230 Apr 9, 2018

Choose a reason for hiding this comment

Uh oh!

jessesuen Apr 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jessesuen Apr 9, 2018 •

edited

Loading