Skip to content

Add last update time to operation status, fix operation status patching#204

Merged
alexmt merged 2 commits intoargoproj:masterfrom
alexmt:operation-last-update-time
May 15, 2018
Merged

Add last update time to operation status, fix operation status patching#204
alexmt merged 2 commits intoargoproj:masterfrom
alexmt:operation-last-update-time

Conversation

@alexmt
Copy link
Collaborator

@alexmt alexmt commented May 15, 2018

No description provided.

@alexmt alexmt requested review from jessesuen and merenbach May 15, 2018 15:16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a startTime, endTime or mTime? If mTime I think it might be clearer to name it such.

Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing my bug. As discussed we'll have StartedAt and FinishedAt instead of LastUpdateTime

@alexmt alexmt force-pushed the operation-last-update-time branch from f56d153 to 0be74c0 Compare May 15, 2018 18:30
@alexmt alexmt merged commit 8039228 into argoproj:master May 15, 2018
@alexmt alexmt deleted the operation-last-update-time branch May 15, 2018 18:35
leoluz pushed a commit to leoluz/argo-cd that referenced this pull request Sep 29, 2023
…che (argoproj#204)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants