Make ApplicationSpec.Destination non-optional, non-pointer#177
Merged
merenbach merged 4 commits intoargoproj:masterfrom May 8, 2018
merenbach:require-destination
Merged
Make ApplicationSpec.Destination non-optional, non-pointer#177merenbach merged 4 commits intoargoproj:masterfrom merenbach:require-destination
merenbach merged 4 commits intoargoproj:masterfrom
merenbach:require-destination
Conversation
jessesuen
reviewed
May 8, 2018
util/argo/argo.go
Outdated
Member
There was a problem hiding this comment.
Do we need this function anymore? I think only Create app needs this logic.
Member
There was a problem hiding this comment.
I searched usages of this and I think we should try removing this since we can now safely assume that server/namespace will be filled out in the object.
Contributor
Author
There was a problem hiding this comment.
Pushed an update that removes this function.
Member
|
jessesuen
approved these changes
May 8, 2018
Member
|
Thanks! |
Contributor
Author
|
leoluz
pushed a commit
to leoluz/argo-cd
that referenced
this pull request
Sep 29, 2023
…nc wave (argoproj#177) Signed-off-by: Jesse Suen <jesse_suen@intuit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #175
@jessesuen is this what we had in mind? Any other changes/additions? I note a mention of immutability—should that be filtering with a conditional upon update attempts?