Make Argo CD naming consistent

[tedmiston]

This small PR changes instances of ArgoCD to Argo CD throughout the repo, and also fixes a few small typos.

Note: There are a few *.pb.go that are generated and I believe should not have been edited, however I'm not sure where I should edit upstream from the generation process. Can you make a suggestion on that?

---

On the official Argo CD product page, docs, and throughout most of this repo, the name is spelled "Argo CD".

• https://argoproj.github.io/argo-cd
• https://blog.argoproj.io/introducing-argo-cd-declarative-continuous-delivery-for-kubernetes-da2a73a780cd

[CLAassistant]

All committers have signed the CLA.

[tedmiston]

I've signed the CLA above, so I believe this PR is now ready for review.

[alexmt]

Thank you for making this cleanup, @tedmiston ! The *.pb.go files are generated using make codegen command (upstream files are *.pb and https://github.com/argoproj/argo-cd/blob/master/pkg/apis/application/v1alpha1/types.go) but it is fine to make changes manually.

You've missed the only one autogenerated file: https://github.com/argoproj/argo-cd/blob/master/server/settings/settings.pb.go#L9

[tedmiston]

@alexmt Thank you for reviewing. I resolved the typo and also freshly rebased off of upstream master. Please let me know if any other revisions should be made.

[jessesuen]

Can we hold off on this while we check with our guy in product marketing? I was a proponent of the single word ArgoCD syntax for SEO purposes.

[tedmiston]

The single word for SEO makes sense.

FWIW, it was me browsing your product site first and seeing Argo CD and not ArgoCD everywhere, then seeing mixed usage in the codebase that motivated this PR.

[I'd also be happy to take this PR in the other direction if ArgoCD is the current preference.]

Sample Google query results:

• "argo cd" site:argoproj.io ~= 15
• "argocd" site:argoproj.io = 0
• "argo cd" site:github.* ~= 1100
• "argocd" site:github.* ~= 773

[tedmiston]

Just wanted to touch base on this PR for canonicalizing the naming to see if any action is required on my end.

[jessesuen]

Just wanted to touch base on this PR for canonicalizing the naming to see if any action is required on my end.

I've been overruled. Argo CD will be the correct usage going forward and not ArgoCD. Once the conflicts are resolved, it should be good to go.

[tedmiston]

Thanks for checking @jessesuen and approving @alexmt.

I've rebased off master and resolved the conflicts. I believe this PR is good to go.

[codecov-io]

Codecov Report

Merging #694 into master will increase coverage by 0.39%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #694      +/-   ##
==========================================
+ Coverage   22.99%   23.38%   +0.39%     
==========================================
  Files          42       42              
  Lines        6253     6349      +96     
==========================================
+ Hits         1438     1485      +47     
- Misses       4626     4668      +42     
- Partials      189      196       +7

Impacted Files	Coverage Δ
util/session/sessionmanager.go	27.41% <ø> (ø)	⬆️
controller/sync.go	28.64% <ø> (ø)	⬆️
util/oidc/oidc.go	2.76% <ø> (ø)	⬆️
util/argo/argo.go	20.06% <ø> (ø)	⬆️
server/project/project.go	63.97% <ø> (ø)	⬆️
controller/state.go	2.89% <ø> (ø)	⬆️
util/kube/kube.go	24.72% <ø> (ø)	⬆️
server/server.go	29.19% <ø> (-1.07%)	⬇️
server/application/application.go	6.77% <0%> (-0.08%)	⬇️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1206926...e24602d. Read the comment docs.