Issue #139 - Application sync should delete 'unexpected' resources#144
Merged
alexmt merged 3 commits intoargoproj:masterfrom May 1, 2018
Merged
Issue #139 - Application sync should delete 'unexpected' resources#144alexmt merged 3 commits intoargoproj:masterfrom
alexmt merged 3 commits intoargoproj:masterfrom
Conversation
|
|
jessesuen
requested changes
Apr 30, 2018
server/application/application.go
Outdated
| if needsCreate { | ||
| resDetails.Message = fmt.Sprintf("will create") | ||
| } else if needsDelete { | ||
| resDetails.Message = fmt.Sprintf("will delete") |
Member
There was a problem hiding this comment.
This needs to take consideration the prune flag. Can we use the term "ignored" if we decide not to delete the resource?
server/application/application.go
Outdated
|
|
||
| resDetails.Message = fmt.Sprintf("deleted") | ||
| } else { | ||
| resDetails.Message = fmt.Sprintf("skipped (should be deleted)") |
…ideration in dry mode
merenbach
approved these changes
Apr 30, 2018
Collaborator
Author
|
@jessesuen your comments are implemented. PTAL |
jessesuen
approved these changes
May 1, 2018
leoluz
pushed a commit
to leoluz/argo-cd
that referenced
this pull request
Sep 29, 2023
argoproj#144) * fix: Hook Deletion Policies HookSucceeded should be run after whole Hook succeed and not only Resource succeed * fix: handle HookFailed. * fix: fixing lint error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #139