Skip to content

Add documentation on project roles and JWT tokens#533

Merged
jessesuen merged 2 commits intoargoproj:masterfrom
dthomson25:JWT-token-docs
Sep 5, 2018
Merged

Add documentation on project roles and JWT tokens#533
jessesuen merged 2 commits intoargoproj:masterfrom
dthomson25:JWT-token-docs

Conversation

@dthomson25
Copy link
Member

No description provided.

@dthomson25
Copy link
Member Author

This PR is for this issue: #519

metadata:
name: argocd-rbac-cm
```
## Project Roles

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dthomson25 - I was not aware of projects (since I used this https://github.com/argoproj/argo-cd/blob/master/docs/getting_started.md ). If customers already know about projects, its okay. But if they do not, can we add a link to docs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After talking to @sindhusrinivasan27, we both agreed that projects are defined earlier in the RBAC page. This makes it reasonable to assume that the customer will have knowledge of projects when they reach this section of the documentation.

@jessesuen
Copy link
Member

LGTM. Let's hold off on merging this until the v0.8 release, in order to reduce confusion if someone is looking at doc directory from tip.

@jessesuen jessesuen merged commit b8e30ed into argoproj:master Sep 5, 2018
@dthomson25 dthomson25 deleted the JWT-token-docs branch January 25, 2019 18:17
leoluz pushed a commit to leoluz/argo-cd that referenced this pull request Sep 29, 2023
Signed-off-by: pashakostohrys <pavel@codefresh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants