Skip to content

Add documentation for helm, application sources, and parameter overrides#466

Merged
jessesuen merged 1 commit intoargoproj:masterfrom
jessesuen:helm-docs
Jul 27, 2018
Merged

Add documentation for helm, application sources, and parameter overrides#466
jessesuen merged 1 commit intoargoproj:masterfrom
jessesuen:helm-docs

Conversation

@jessesuen
Copy link
Member

@jessesuen jessesuen commented Jul 26, 2018

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few minor comments

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking: demonstrates -> demonstrate

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An repository -> A repository

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public available -> publicly available

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ssetSince -> Since

@jessesuen
Copy link
Member Author

Thanks for reviewing so carefully. Will make the changes.

@jessesuen
Copy link
Member Author

Holding off on merging docs until release is cut.

@jessesuen jessesuen merged commit c9d5f2e into argoproj:master Jul 27, 2018
leoluz pushed a commit to leoluz/argo-cd that referenced this pull request Sep 29, 2023
Signed-off-by: ls0f <lovedboy.tk@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants