Revert "Validate Ksonnet apps through component dir presence (#708)"#730
Merged
alexmt merged 1 commit intoargoproj:masterfrom Oct 29, 2018
merenbach:revert-594-better-ksonnet-detection
Merged
Revert "Validate Ksonnet apps through component dir presence (#708)"#730alexmt merged 1 commit intoargoproj:masterfrom merenbach:revert-594-better-ksonnet-detection
alexmt merged 1 commit intoargoproj:masterfrom
merenbach:revert-594-better-ksonnet-detection
Conversation
This reverts commit 1844be6.
Codecov Report
@@ Coverage Diff @@
## master #730 +/- ##
==========================================
- Coverage 22.05% 22.04% -0.02%
==========================================
Files 40 40
Lines 6288 6287 -1
==========================================
- Hits 1387 1386 -1
Misses 4714 4714
Partials 187 187
Continue to review full report at Codecov.
|
alexmt
approved these changes
Oct 29, 2018
ppapapetrou76
pushed a commit
to ppapapetrou76/argo-cd
that referenced
this pull request
Aug 19, 2025
…#708)" (argoproj#730) * Revert "Add option to skip the dryrun from the sync context (argoproj#708)" This reverts commit 717b8bf. Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * format Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 1844be6 from #708, which has demonstrated output inconsistent with the testing performed.