Skip to content

add argo cluster permission to view logs#766

Merged
alexmt merged 1 commit intoargoproj:masterfrom
conorfennell:fix-log
Nov 13, 2018
Merged

add argo cluster permission to view logs#766
alexmt merged 1 commit intoargoproj:masterfrom
conorfennell:fix-log

Conversation

@conorfennell
Copy link
Contributor

Fix viewing logs from the ArgoCD UI.

@codecov-io
Copy link

codecov-io commented Nov 13, 2018

Codecov Report

Merging #766 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #766   +/-   ##
=======================================
  Coverage   26.47%   26.47%           
=======================================
  Files          41       41           
  Lines        6337     6337           
=======================================
  Hits         1678     1678           
  Misses       4426     4426           
  Partials      233      233

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49e022a...c0c0996. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@alexmt alexmt merged commit ffa0c34 into argoproj:master Nov 13, 2018
leoluz pushed a commit to leoluz/argo-cd that referenced this pull request Sep 23, 2025
argoproj#766)

* Adds a script to prepare repo for migration to main ArgoCD Repo

Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>

* remove also .gitignore

Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>

* fix script

Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>

* address pr comments

Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>

---------

Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants