add metrics label for service monitor discovery#765
Merged
alexmt merged 1 commit intoargoproj:masterfrom Nov 14, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #765 +/- ##
=======================================
Coverage 26.51% 26.51%
=======================================
Files 41 41
Lines 6340 6340
=======================================
Hits 1681 1681
Misses 4426 4426
Partials 233 233Continue to review full report at Codecov.
|
alexmt
requested changes
Nov 13, 2018
Collaborator
alexmt
left a comment
alexmt
left a comment
There was a problem hiding this comment.
Thank you for contribution @conorfennell !
Please add app label to manifests/namespace-install.yaml as well. Both manifests/install.yaml and manifests/namespace-install.yaml are auto-generated. You can run ./hack/update-manifests.sh to update them.
Contributor
Author
|
@alexmt Done |
leoluz
pushed a commit
to leoluz/argo-cd
that referenced
this pull request
Sep 23, 2025
…uster scoped resources (argoproj#765) * Using live obj to get the resource key if not nil Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Fixed failing unit tests Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Added test case for validating cluster scoped resources with ApplyOutOfSyncOnly=true Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Fixed gofumpt formatting errors Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Corrected unit tests for cluster scoped resources Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Removed unwanted code comments Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Added comments for explaining the reason why ns is set from live object Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> * Added comments in the unit test Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com> --------- Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServiceMonitor, the Prometheus operator's custom resource definition discovers Service's by label.
Currently the metrics service yaml defintions do not have any label, this pull request adds one so the Service can be use to be discovered by the Prometheus operator.