Skip to content

(resolves 254 ) update getting started to work for post 0.6#369

Closed
JazminElkan-Gonzalez wants to merge 7 commits intomasterfrom
JazminGonzalez-Rivero-patch-1
Closed

(resolves 254 ) update getting started to work for post 0.6#369
JazminElkan-Gonzalez wants to merge 7 commits intomasterfrom
JazminGonzalez-Rivero-patch-1

Conversation

@JazminElkan-Gonzalez
Copy link
Contributor

Do not merge until after 0.6 is released

@JazminElkan-Gonzalez
Copy link
Contributor Author

@jessesuen this is the docs update that we will need to push out once the new version of argo-cd is out and we are no longer relying on the install script.

@jessesuen
Copy link
Member

Some improvements:

  1. I'd like to remove the requirement that a user has to git clone our repo to install ArgoCD. Instead, we should have instructions like:
kubectl apply -f https://github.com/argoproj/argo-cd/blob/master/manifests/install.yaml

I think we should re-organize our manifests to the following structure:

manifests/
    install.yaml
    components/
        01a_application-crd.yaml
        01b_appproject-crd.yaml

Our makefile should autogenerate install.yaml during build by doing:
cat manifests/components/*.yaml > manifests/install.yaml

  1. Let's also remove the 00_namespace.yaml and instruct the user to create their own namespace. This will make install.yaml completely portable. So the instructions then become:
kubectl create namespace argocd
kubectl apply -n argocd -f https://github.com/argoproj/argo-cd/blob/master/manifests/install.yaml

@bhack
Copy link

bhack commented Jul 11, 2018

It could be nice to simplify the install with an official helm chart.

@JazminElkan-Gonzalez
Copy link
Contributor Author

@jessesuen that totally makes sense, forgot this would be used outside of a developer context.
I have updated the PR appropriately.

for 2. is this just so the user can use different namespaces a bit easier? (I also made the change to match this, just wondering the benefits)

for the helm trade off, this feels like a larger change and I the use-case for these manifests is rather small so not sure if such a change is needed at this time. but I'll bring it up during standup today and we can review it.

@jessesuen
Copy link
Member

  1. is this just so the user can use different namespaces a bit easier? (I also made the change to match this, just wondering the benefits)

Correct. If we create the namespace for them, then they have no options.

It could be nice to simplify the install with an official helm chart.

I'm not opposed to this, but I think it can wait until we start pushing adoption.

kubectl apply -f manifests/. --namespace argocd
```
This will create a new namespace, `argocd`, where ArgoCD services and application resources will live.
This will create a new namespace, `argocd`; where ArgoCD services and application resources will live.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These instructions still need to change to kubectl apply http://..../install.yaml

Copy link
Contributor Author

@JazminElkan-Gonzalez JazminElkan-Gonzalez Jul 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, oops. updated @jessesuen

Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please don't merge until we cut a v0.6 release

```
This will create a new namespace, `argocd`; where ArgoCD services and application resources will live.
This will create a new namespace, `argocd` where ArgoCD services and application resources will live.
This will also create key replicasets, deployments and services needed for ArgoCD
Copy link
Member

@jessesuen jessesuen Jul 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also create key replicasets, deployments and services needed for ArgoCD

I think this statement is a little confusing: we don't explicitly create replicasets since they are implicitly created by our deployments. Also the fact that we create a deployment/service should also be obvious.

```
This will create a new namespace, `argocd`, where ArgoCD services and application resources will live.
This will create a new namespace, `argocd` where ArgoCD services and application resources will live.
This will also create key replicasets, deployments and services needed for ArgoCD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we're missing a step between step 2 and 3. We need instructions on how to login to ArgoCD using the pod name as the password.

Also, it seems like we should have a API to reset password. I'll file another issue for this. I think it's important for v0.6

@JazminElkan-Gonzalez JazminElkan-Gonzalez deleted the JazminGonzalez-Rivero-patch-1 branch July 17, 2018 22:55
leoluz pushed a commit to leoluz/argo-cd that referenced this pull request Sep 29, 2023
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants