(resolves 254 ) update getting started to work for post 0.6#369
(resolves 254 ) update getting started to work for post 0.6#369JazminElkan-Gonzalez wants to merge 7 commits intomasterfrom
Conversation
Do not merge until after 0.6 is released
|
@jessesuen this is the docs update that we will need to push out once the new version of argo-cd is out and we are no longer relying on the install script. |
|
Some improvements:
I think we should re-organize our manifests to the following structure: Our makefile should autogenerate
|
|
It could be nice to simplify the install with an official helm chart. |
|
@jessesuen that totally makes sense, forgot this would be used outside of a developer context. for 2. is this just so the user can use different namespaces a bit easier? (I also made the change to match this, just wondering the benefits) for the helm trade off, this feels like a larger change and I the use-case for these manifests is rather small so not sure if such a change is needed at this time. but I'll bring it up during standup today and we can review it. |
Correct. If we create the namespace for them, then they have no options.
I'm not opposed to this, but I think it can wait until we start pushing adoption. |
docs/getting_started.md
Outdated
| kubectl apply -f manifests/. --namespace argocd | ||
| ``` | ||
| This will create a new namespace, `argocd`, where ArgoCD services and application resources will live. | ||
| This will create a new namespace, `argocd`; where ArgoCD services and application resources will live. |
There was a problem hiding this comment.
These instructions still need to change to kubectl apply http://..../install.yaml
jessesuen
left a comment
There was a problem hiding this comment.
LGTM! Please don't merge until we cut a v0.6 release
| ``` | ||
| This will create a new namespace, `argocd`; where ArgoCD services and application resources will live. | ||
| This will create a new namespace, `argocd` where ArgoCD services and application resources will live. | ||
| This will also create key replicasets, deployments and services needed for ArgoCD |
There was a problem hiding this comment.
This will also create key replicasets, deployments and services needed for ArgoCD
I think this statement is a little confusing: we don't explicitly create replicasets since they are implicitly created by our deployments. Also the fact that we create a deployment/service should also be obvious.
| ``` | ||
| This will create a new namespace, `argocd`, where ArgoCD services and application resources will live. | ||
| This will create a new namespace, `argocd` where ArgoCD services and application resources will live. | ||
| This will also create key replicasets, deployments and services needed for ArgoCD |
There was a problem hiding this comment.
It looks like we're missing a step between step 2 and 3. We need instructions on how to login to ArgoCD using the pod name as the password.
Also, it seems like we should have a API to reset password. I'll file another issue for this. I think it's important for v0.6
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Do not merge until after 0.6 is released