Remove default params from app history#649
Merged
dthomson25 merged 1 commit intoargoproj:masterfrom Sep 27, 2018
Merged
Conversation
jessesuen
reviewed
Sep 26, 2018
Member
There was a problem hiding this comment.
It's not safe to renumber. Just remove the field and let the others keep their existing numbers.
jessesuen
reviewed
Sep 26, 2018
Member
There was a problem hiding this comment.
Same comment. Protobufs should never be renumbered or backwards compatibility is broken.
alexmt
approved these changes
Sep 26, 2018
Collaborator
alexmt
left a comment
alexmt
left a comment
There was a problem hiding this comment.
LGTM. Please address @jessesuen 's comments about protobuf re-numbering .
dthomson25
force-pushed
the
move-params
branch
from
296485c to
b073091
Compare
ppapapetrou76
pushed a commit
to ppapapetrou76/argo-cd
that referenced
this pull request
Aug 19, 2025
…dfb36dea90c5e3689 to 5c47607acb93fed5485fdbf7232e8a31425f672a (argoproj#649) * chore(deps): bump codecov/codecov-action Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from a2f73fb6db51fcd2e0aa085dfb36dea90c5e3689 to 5c47607acb93fed5485fdbf7232e8a31425f672a. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@a2f73fb...5c47607) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Update ci.yaml --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves for #556