Expand Git repo URL normalization#162
Merged
merenbach merged 13 commits intoargoproj:masterfrom May 5, 2018
merenbach:normalize-git-repos
Merged
Expand Git repo URL normalization#162merenbach merged 13 commits intoargoproj:masterfrom merenbach:normalize-git-repos
merenbach merged 13 commits intoargoproj:masterfrom
merenbach:normalize-git-repos
Conversation
jessesuen
reviewed
May 5, 2018
util/git/git_test.go
Outdated
Member
There was a problem hiding this comment.
Can we add some tests where the input is missing the .git suffix, and added after normalization?
jessesuen
approved these changes
May 5, 2018
Member
jessesuen
left a comment
There was a problem hiding this comment.
Thanks for the thorough job and tests!
jessesuen
reviewed
May 5, 2018
server/repository/repository_test.go
Outdated
Member
There was a problem hiding this comment.
Can we add one where "https://github.com/argoproj/argo-cd.git" also maps to "repo-argo-cd-821842295"
added 13 commits
May 4, 2018 17:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To resolve #138:
.gitsuffix during normalization. This will break all existing repos that were added without a.gitsuffix, thanks to hashing differences.git@(existing behavior) or if they begin withssh://(new behavior). All SSH prefixes will be stripped at the end of the normalization process.util/gitmodule.