Convert Kubernetes errors to gRPC errors#89
Merged
merenbach merged 3 commits intoargoproj:masterfrom Apr 17, 2018
merenbach:convert-errors
Merged
Convert Kubernetes errors to gRPC errors#89merenbach merged 3 commits intoargoproj:masterfrom merenbach:convert-errors
merenbach merged 3 commits intoargoproj:masterfrom
merenbach:convert-errors
Conversation
jessesuen
approved these changes
Apr 17, 2018
Collaborator
|
LGTM |
alexmt
approved these changes
Apr 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #30 by adding interceptors to convert error codes from Kubernetes errors (the identities of which may be tested using functions) into numeric codes for more appropriate gRPC responses.