Skip to content

chore: migrate gitops engine by preserving history#24293

Closed
ppapapetrou76 wants to merge 370 commits intoargoproj:masterfrom
ppapapetrou76:migrate-gitops-engine
Closed

chore: migrate gitops engine by preserving history#24293
ppapapetrou76 wants to merge 370 commits intoargoproj:masterfrom
ppapapetrou76:migrate-gitops-engine

Conversation

@ppapapetrou76
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Alexander Matyushentsev and others added 30 commits August 27, 2020 17:33
…odical K8S API state resynchronization (argoproj#133)

* fix: leverage RetryWatcher to watch cluster events and introduce periodical K8S API state resynchronization

* Apply reviewer notes

* enable race detection in tests
Bumps [actions/setup-go](https://github.com/actions/setup-go) from v2.1.1 to v2.1.2.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v2.1.1...8a3a76c)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- print using test logger
- print using fmt - println use is discouraged
…oproj#120)

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from v1.0.12 to v1.0.13.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Commits](codecov/codecov-action@v1.0.12...6004246)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
argoproj#136)

* fix: health status is set to healthy for statefulset with updateStrategy: OnDelete

* fix: updated message

* fix: added test
…oj#137)

* fix: health status is set to healthy for statefulset with updateStrategy: OnDelete

* fix: updated message

* fix: added test

* fix: health status for daemon set with Ondelete updateStrategy
argoproj#141)

* fix: Support transition from a git managed namespace to auto-create namespace

* fix: Support transition from a git managed namespace to auto-create namespace

* fix: use sync task to remove label

* fix: withNamespaceCreation

* fix: fix failed test

* fix: remove obsolete comment.
argoproj#144)

* fix: Hook Deletion Policies HookSucceeded should be run after whole Hook succeed and not only Resource succeed

* fix: handle HookFailed.

* fix: fixing lint error.
Bumps [actions/setup-go](https://github.com/actions/setup-go) from v2.1.2 to v2.1.3.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v2.1.2...37335c7)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…oj#173)

Bumps [github.com/go-logr/logr](https://github.com/go-logr/logr) from 0.2.0 to 0.2.1.
- [Release notes](https://github.com/go-logr/logr/releases)
- [Commits](go-logr/logr@v0.2.0...v0.2.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…nc wave (argoproj#177)

Signed-off-by: Jesse Suen <jesse_suen@intuit.com>
Signed-off-by: Mikhail Mazurskiy <mmazurskiy@gitlab.com>
…#180)

Signed-off-by: yutachaos <18604471+yutachaos@users.noreply.github.com>
…me hooks properly (argoproj#183)

Signed-off-by: Jesse Suen <jessesuen@gmail.com>
* panic: interface conversion: interface {} is string

Signed-off-by: May Zhang <may_zhang@intuit.com>
…rgoproj#190)

* fix: HPA health check is making incorrect assumption on annotations

Signed-off-by: May Zhang <may_zhang@intuit.com>

* fix: added handle of v1, v2beta1 and v2beta2

Signed-off-by: May Zhang <may_zhang@intuit.com>

* fix: clean up test data file

Signed-off-by: May Zhang <may_zhang@intuit.com>
crenshaw-dev and others added 16 commits June 6, 2025 10:49
* chore: wrap errors

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* report list result along with error

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fixes

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
…#727)

* feat: auto migrate kubectl-client-side-apply fields for SSA

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* fix master version

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* run gofumpt

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* Propagate sync error instead of logging

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* allow enable/disable of CSA migration using annotation

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* fix linting

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* Refactor to allow for multiple managers and disable option

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* remove commentj

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* refactor

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* fix test

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* Add docs for client side apply migration

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* Edit comment

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

---------

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
…#708)" (argoproj#730)

* Revert "Add option to skip the dryrun from the sync context (argoproj#708)"

This reverts commit 717b8bf.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* format

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
* upgrade k8s to 1.33.1

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* fix linter issues

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

---------

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
* chore: Cleanup IterateHierarchy v1

Part of argoproj#23854

Remove the unused code in gitops-engine.

Signed-off-by: Andrii Korotkov <myolymp@gmail.com>

* Revert some deleted tests

Signed-off-by: Andrii Korotkov <myolymp@gmail.com>

---------

Signed-off-by: Andrii Korotkov <myolymp@gmail.com>
…rgoproj#747)

* WIP fix: update normalization for ignoreDifferences on server-side diff

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* fix linter

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* refactor

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* skip pre-normalization for ssd

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* skip pre-normalization for ssd

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* docs

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* modify Normalize to skip ignoreDifferences conditionally

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* ignoreDifferences for SSD and test backwards compatible

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* rename flags for clarity

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

* doc change

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>

---------

Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: rafal-jan <rafal7jan@gmail.com>
Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>
Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>
Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>
Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>
Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>
@ppapapetrou76 ppapapetrou76 requested review from a team as code owners August 27, 2025 14:19
@bunnyshell
Copy link

bunnyshell bot commented Aug 27, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.38%. Comparing base (8c3b78e) to head (71c46eb).
⚠️ Report is 846 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #24293      +/-   ##
==========================================
+ Coverage   60.20%   60.38%   +0.18%     
==========================================
  Files         348      402      +54     
  Lines       59918    65754    +5836     
==========================================
+ Hits        36074    39708    +3634     
- Misses      20951    22842    +1891     
- Partials     2893     3204     +311     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ppapapetrou76 and others added 2 commits August 27, 2025 20:15
Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>
@ppapapetrou76 ppapapetrou76 force-pushed the migrate-gitops-engine branch from 45ddac3 to c773dc5 Compare August 28, 2025 09:05
Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>
@ppapapetrou76 ppapapetrou76 force-pushed the migrate-gitops-engine branch from 109bab0 to 45dfa86 Compare August 28, 2025 09:15
ppapapetrou76 and others added 2 commits August 28, 2025 13:25
Signed-off-by: Patroklos Papapetrou <ppapapetrou76@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.