Argo server should not fail if configmap name is not provided or config map does not exist#55
Merged
alexmt merged 2 commits intoargoproj:masterfrom Mar 27, 2018
Merged
Conversation
…ig map does not exist
merenbach
approved these changes
Mar 27, 2018
Contributor
merenbach
left a comment
merenbach
left a comment
There was a problem hiding this comment.
Looks good overall. Please see comment regarding magic number (well, string).
cmd/argocd-server/commands/root.go
Outdated
| command.Flags().StringVar(&logLevel, "loglevel", "info", "Set the logging level. One of: debug|info|warn|error") | ||
| command.Flags().StringVar(&repoServerAddress, "repo-server", "localhost:8081", "Repo server address.") | ||
| command.Flags().StringVar(&configMapName, "config-map", "", "Name of a Kubernetes config map to use.") | ||
| command.Flags().StringVar(&configMapName, "config-map", "argo-cd-cm", "Name of a Kubernetes config map to use.") |
Contributor
There was a problem hiding this comment.
Might it make sense to replace "argo-cd-cm" with a util.ConfigManagerDefaultConfigMapName const? That way the same default const can be used between argocd install and argocd-server.
Collaborator
Author
There was a problem hiding this comment.
@merenbach for some reason I cannot find ConfigManagerDefaultConfigMapName const. Is it in master or some other branch?
Contributor
There was a problem hiding this comment.
@alexmt I should have clarified. This would be a new const in util/configmanager.go. You could name it whatever seems appropriate. It would reduce hardcoding, especially since I suspect we could have that config map default name in more than one location: once during install, once during server runtime.
Collaborator
Author
There was a problem hiding this comment.
Got it. It make sense, working on changes
Collaborator
Author
|
@merenbach please take another look. I had to make more changes in intall.go to handle situation when config-map name is not provided by user, but kubernetes has config map with default name exist and has non-default secret name. |
Contributor
|
@alexmt looks good to me! |
alexec
pushed a commit
that referenced
this pull request
Apr 24, 2019
leoluz
pushed a commit
to leoluz/argo-cd
that referenced
this pull request
Sep 29, 2023
…j#55) * feat: support limiting number of concurrent k8s list queries
alexmt
pushed a commit
to alexmt/argo-cd
that referenced
this pull request
Oct 28, 2024
gdsoumya
pushed a commit
to gdsoumya/argo-cd
that referenced
this pull request
Nov 8, 2024
alexmt
pushed a commit
to alexmt/argo-cd
that referenced
this pull request
Dec 6, 2024
alexmt
pushed a commit
to alexmt/argo-cd
that referenced
this pull request
Dec 16, 2024
alexmt
pushed a commit
to alexmt/argo-cd
that referenced
this pull request
Dec 20, 2024
alexmt
pushed a commit
to alexmt/argo-cd
that referenced
this pull request
Jan 17, 2025
alexmt
pushed a commit
to alexmt/argo-cd
that referenced
this pull request
Feb 28, 2025
alexmt
pushed a commit
to alexmt/argo-cd
that referenced
this pull request
Mar 27, 2025
alexmt
pushed a commit
to alexmt/argo-cd
that referenced
this pull request
Apr 3, 2025
alexmt
pushed a commit
to alexmt/argo-cd
that referenced
this pull request
May 22, 2025
alexmt
pushed a commit
to alexmt/argo-cd
that referenced
this pull request
Jul 1, 2025
gdsoumya
pushed a commit
to gdsoumya/argo-cd
that referenced
this pull request
Jul 7, 2025
gdsoumya
pushed a commit
to gdsoumya/argo-cd
that referenced
this pull request
Jul 10, 2025
alexmt
pushed a commit
to alexmt/argo-cd
that referenced
this pull request
Jul 11, 2025
alexmt
pushed a commit
to alexmt/argo-cd
that referenced
this pull request
Jul 22, 2025
alexmt
pushed a commit
to alexmt/argo-cd
that referenced
this pull request
Nov 20, 2025
alexmt
added a commit
to alexmt/argo-cd
that referenced
this pull request
Nov 20, 2025
* chore: disable dependabot Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: user server side filtering & pagination to load Argo CD applications list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix cluster filtering and refresh button on application list page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: api server fails with "nil pointer dereference" error (argoproj#40) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): ui should show the same page number as in API (argoproj#38) * feat: repository/Service.ListRefs returns raw list of refs (argoproj#42) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat(multi-cluster k8s dashboard): Make necessary changes for multi-cluster k8s dashboard feature in AKP (argoproj#48) * feat: send data to agent Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * (wip)feat: send data to syncer APIs * add support for columns info * fix: resource deletion missing events * feat: use resource sync and health info * chore: disable dependabot Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: user server side filtering & pagination to load Argo CD applications list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix cluster filtering and refresh button on application list page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: api server fails with "nil pointer dereference" error (argoproj#40) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): ui should show the same page number as in API (argoproj#38) * feat: repository/Service.ListRefs returns raw list of refs (argoproj#42) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): Reoreding filters (argoproj#44) * fix(ui): Reoreding filters * fix * fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: enable dashboard feature by using env var * fix: 1.21.0 -> 1.21 * chore: disable dependabot Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: user server side filtering & pagination to load Argo CD applications list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix cluster filtering and refresh button on application list page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: api server fails with "nil pointer dereference" error (argoproj#40) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): ui should show the same page number as in API (argoproj#38) * feat: repository/Service.ListRefs returns raw list of refs (argoproj#42) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): Reoreding filters (argoproj#44) * fix(ui): Reoreding filters * fix * fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Mayursinh Sarvaiya <marvinduff97@gmail.com> Co-authored-by: Rafal <rafpelczar@gmail.com> * fix: using http client with timeout (argoproj#51) * feat: send api resource count and object count from argocd application controller (argoproj#52) * feat: add destination metadata for argocd UI repo calls (argoproj#53) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * fix: argocd only send cluster info once (argoproj#54) * send all health statuses (argoproj#55) * feat: added commit abilities to reposerver (argoproj#56) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * chore: use FedRAMP compliant binaries (argoproj#57) Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com> * feat: implement resource filtering in app source and app filtering in appset (argoproj#58) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: helm binary path in image (argoproj#59) * fix: application set should not attempt to talk to managed cluster (argoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): Application stats flickers (argoproj#61) * feat: add cluster scoped for kubevision resource info (argoproj#62) * add namespaced * use cluster scoped * use v5 * fix: api server uses invalid matching while checking app namespace (argoproj#63) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: Undefined in Argo CD apps search box and app-in-any-namespace enabled (argoproj#64) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: support reading notifications settings from a different k8s (argoproj#66) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: add akuity-release-cli (argoproj#67) * feat: add akuity-release-cli Signed-off-by: Justin Marquis <justin@akuity.io> * go mod tidy Signed-off-by: Justin Marquis <justin@akuity.io> --------- Signed-off-by: Justin Marquis <justin@akuity.io> * fix: akuity-release-cli (argoproj#68) Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * add skipOnFailure flag to appset filters (argoproj#69) * fix(appset): improve git generator repo credential fallback (argoproj#21167) * fix: read settings from host namespace instead of control plane namespace (argoproj#70) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: add support for deleting files/dir in repo server (argoproj#71) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: store original URL in global variable (argoproj#72) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: argocd app controller should not be affected when syncer is down (argoproj#73) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: handle delegated appset generate cli calls (argoproj#74) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * refactor: local generate condition (argoproj#75) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: ensure appset generate call also filters the apps (argoproj#76) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: appset generator cannot access app metadata (argoproj#77) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: circular dependency error Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix sync status missing (argoproj#78) * feat: favorite application filter (argoproj#79) * feat: favorite filter * feat: test * fix: ap.pb.go * fix: application-list * fix: remove duplicate * fix: proto * fix: pagination for fav * remove: debug logs Signed-off-by: bhavyabhut <pbhavy4@gmail.com> --------- Signed-off-by: bhavyabhut <pbhavy4@gmail.com> * feat: add replace handler to power dashboard (argoproj#82) Co-authored-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com> * handle only when repo-server delegated * fix typo * cache redis clients Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com> Signed-off-by: Justin Marquis <justin@akuity.io> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: bhavyabhut <pbhavy4@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Mayursinh Sarvaiya <marvinduff97@gmail.com> Co-authored-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com> Co-authored-by: Rafal <rafpelczar@gmail.com> Co-authored-by: Soumya Ghosh Dastidar <44349253+gdsoumya@users.noreply.github.com> Co-authored-by: Xiaopeng Han <hanxiaop8@outlook.com> Co-authored-by: Anubhav Gupta <mail.anubhav06@gmail.com> Co-authored-by: Rafal <rafal@akuity.io> Co-authored-by: Yiwei Gong <imwithye@gmail.com> Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com> Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Bhavya Bhut <pbhavy4@gmail.com>
alexmt
pushed a commit
to alexmt/argo-cd
that referenced
this pull request
Jan 13, 2026
alexmt
added a commit
to alexmt/argo-cd
that referenced
this pull request
Jan 13, 2026
* chore: disable dependabot Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: user server side filtering & pagination to load Argo CD applications list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix cluster filtering and refresh button on application list page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: api server fails with "nil pointer dereference" error (argoproj#40) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): ui should show the same page number as in API (argoproj#38) * feat: repository/Service.ListRefs returns raw list of refs (argoproj#42) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat(multi-cluster k8s dashboard): Make necessary changes for multi-cluster k8s dashboard feature in AKP (argoproj#48) * feat: send data to agent Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * (wip)feat: send data to syncer APIs * add support for columns info * fix: resource deletion missing events * feat: use resource sync and health info * chore: disable dependabot Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: user server side filtering & pagination to load Argo CD applications list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix cluster filtering and refresh button on application list page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: api server fails with "nil pointer dereference" error (argoproj#40) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): ui should show the same page number as in API (argoproj#38) * feat: repository/Service.ListRefs returns raw list of refs (argoproj#42) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): Reoreding filters (argoproj#44) * fix(ui): Reoreding filters * fix * fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: enable dashboard feature by using env var * fix: 1.21.0 -> 1.21 * chore: disable dependabot Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: user server side filtering & pagination to load Argo CD applications list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix cluster filtering and refresh button on application list page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: api server fails with "nil pointer dereference" error (argoproj#40) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): ui should show the same page number as in API (argoproj#38) * feat: repository/Service.ListRefs returns raw list of refs (argoproj#42) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): Reoreding filters (argoproj#44) * fix(ui): Reoreding filters * fix * fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Mayursinh Sarvaiya <marvinduff97@gmail.com> Co-authored-by: Rafal <rafpelczar@gmail.com> * fix: using http client with timeout (argoproj#51) * feat: send api resource count and object count from argocd application controller (argoproj#52) * feat: add destination metadata for argocd UI repo calls (argoproj#53) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * fix: argocd only send cluster info once (argoproj#54) * send all health statuses (argoproj#55) * feat: added commit abilities to reposerver (argoproj#56) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * chore: use FedRAMP compliant binaries (argoproj#57) Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com> * feat: implement resource filtering in app source and app filtering in appset (argoproj#58) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: helm binary path in image (argoproj#59) * fix: application set should not attempt to talk to managed cluster (argoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): Application stats flickers (argoproj#61) * feat: add cluster scoped for kubevision resource info (argoproj#62) * add namespaced * use cluster scoped * use v5 * fix: api server uses invalid matching while checking app namespace (argoproj#63) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: Undefined in Argo CD apps search box and app-in-any-namespace enabled (argoproj#64) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: support reading notifications settings from a different k8s (argoproj#66) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: add akuity-release-cli (argoproj#67) * feat: add akuity-release-cli Signed-off-by: Justin Marquis <justin@akuity.io> * go mod tidy Signed-off-by: Justin Marquis <justin@akuity.io> --------- Signed-off-by: Justin Marquis <justin@akuity.io> * fix: akuity-release-cli (argoproj#68) Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * add skipOnFailure flag to appset filters (argoproj#69) * fix(appset): improve git generator repo credential fallback (argoproj#21167) * fix: read settings from host namespace instead of control plane namespace (argoproj#70) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: add support for deleting files/dir in repo server (argoproj#71) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: store original URL in global variable (argoproj#72) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: argocd app controller should not be affected when syncer is down (argoproj#73) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: handle delegated appset generate cli calls (argoproj#74) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * refactor: local generate condition (argoproj#75) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: ensure appset generate call also filters the apps (argoproj#76) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: appset generator cannot access app metadata (argoproj#77) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: circular dependency error Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix sync status missing (argoproj#78) * feat: favorite application filter (argoproj#79) * feat: favorite filter * feat: test * fix: ap.pb.go * fix: application-list * fix: remove duplicate * fix: proto * fix: pagination for fav * remove: debug logs Signed-off-by: bhavyabhut <pbhavy4@gmail.com> --------- Signed-off-by: bhavyabhut <pbhavy4@gmail.com> * feat: add replace handler to power dashboard (argoproj#82) Co-authored-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com> * handle only when repo-server delegated * fix typo * cache redis clients Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com> Signed-off-by: Justin Marquis <justin@akuity.io> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: bhavyabhut <pbhavy4@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Mayursinh Sarvaiya <marvinduff97@gmail.com> Co-authored-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com> Co-authored-by: Rafal <rafpelczar@gmail.com> Co-authored-by: Soumya Ghosh Dastidar <44349253+gdsoumya@users.noreply.github.com> Co-authored-by: Xiaopeng Han <hanxiaop8@outlook.com> Co-authored-by: Anubhav Gupta <mail.anubhav06@gmail.com> Co-authored-by: Rafal <rafal@akuity.io> Co-authored-by: Yiwei Gong <imwithye@gmail.com> Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com> Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Bhavya Bhut <pbhavy4@gmail.com>
alexmt
pushed a commit
to alexmt/argo-cd
that referenced
this pull request
Mar 21, 2026
alexmt
added a commit
to alexmt/argo-cd
that referenced
this pull request
Mar 21, 2026
* chore: disable dependabot Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: user server side filtering & pagination to load Argo CD applications list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix cluster filtering and refresh button on application list page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: api server fails with "nil pointer dereference" error (argoproj#40) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): ui should show the same page number as in API (argoproj#38) * feat: repository/Service.ListRefs returns raw list of refs (argoproj#42) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat(multi-cluster k8s dashboard): Make necessary changes for multi-cluster k8s dashboard feature in AKP (argoproj#48) * feat: send data to agent Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * (wip)feat: send data to syncer APIs * add support for columns info * fix: resource deletion missing events * feat: use resource sync and health info * chore: disable dependabot Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: user server side filtering & pagination to load Argo CD applications list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix cluster filtering and refresh button on application list page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: api server fails with "nil pointer dereference" error (argoproj#40) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): ui should show the same page number as in API (argoproj#38) * feat: repository/Service.ListRefs returns raw list of refs (argoproj#42) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): Reoreding filters (argoproj#44) * fix(ui): Reoreding filters * fix * fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: enable dashboard feature by using env var * fix: 1.21.0 -> 1.21 * chore: disable dependabot Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: user server side filtering & pagination to load Argo CD applications list Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix cluster filtering and refresh button on application list page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: api server fails with "nil pointer dereference" error (argoproj#40) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): ui should show the same page number as in API (argoproj#38) * feat: repository/Service.ListRefs returns raw list of refs (argoproj#42) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: avoid closing search dropdown while typing; fix cluster filter (argoproj#43) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): Reoreding filters (argoproj#44) * fix(ui): Reoreding filters * fix * fix: -ak.19 server version causing argocd app wait command to hang (argoproj#45) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Mayursinh Sarvaiya <marvinduff97@gmail.com> Co-authored-by: Rafal <rafpelczar@gmail.com> * fix: using http client with timeout (argoproj#51) * feat: send api resource count and object count from argocd application controller (argoproj#52) * feat: add destination metadata for argocd UI repo calls (argoproj#53) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * fix: argocd only send cluster info once (argoproj#54) * send all health statuses (argoproj#55) * feat: added commit abilities to reposerver (argoproj#56) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * chore: use FedRAMP compliant binaries (argoproj#57) Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com> * feat: implement resource filtering in app source and app filtering in appset (argoproj#58) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: helm binary path in image (argoproj#59) * fix: application set should not attempt to talk to managed cluster (argoproj#60) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix(ui): Application stats flickers (argoproj#61) * feat: add cluster scoped for kubevision resource info (argoproj#62) * add namespaced * use cluster scoped * use v5 * fix: api server uses invalid matching while checking app namespace (argoproj#63) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: Undefined in Argo CD apps search box and app-in-any-namespace enabled (argoproj#64) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: support reading notifications settings from a different k8s (argoproj#66) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: add akuity-release-cli (argoproj#67) * feat: add akuity-release-cli Signed-off-by: Justin Marquis <justin@akuity.io> * go mod tidy Signed-off-by: Justin Marquis <justin@akuity.io> --------- Signed-off-by: Justin Marquis <justin@akuity.io> * fix: akuity-release-cli (argoproj#68) Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> * add skipOnFailure flag to appset filters (argoproj#69) * fix(appset): improve git generator repo credential fallback (argoproj#21167) * fix: read settings from host namespace instead of control plane namespace (argoproj#70) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: add support for deleting files/dir in repo server (argoproj#71) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: store original URL in global variable (argoproj#72) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: argocd app controller should not be affected when syncer is down (argoproj#73) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * feat: handle delegated appset generate cli calls (argoproj#74) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * refactor: local generate condition (argoproj#75) Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> * feat: ensure appset generate call also filters the apps (argoproj#76) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: appset generator cannot access app metadata (argoproj#77) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: circular dependency error Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix sync status missing (argoproj#78) * feat: favorite application filter (argoproj#79) * feat: favorite filter * feat: test * fix: ap.pb.go * fix: application-list * fix: remove duplicate * fix: proto * fix: pagination for fav * remove: debug logs Signed-off-by: bhavyabhut <pbhavy4@gmail.com> --------- Signed-off-by: bhavyabhut <pbhavy4@gmail.com> * feat: add replace handler to power dashboard (argoproj#82) Co-authored-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com> * handle only when repo-server delegated * fix typo * cache redis clients Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com> Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com> Signed-off-by: Justin Marquis <justin@akuity.io> Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: bhavyabhut <pbhavy4@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Mayursinh Sarvaiya <marvinduff97@gmail.com> Co-authored-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com> Co-authored-by: Rafal <rafpelczar@gmail.com> Co-authored-by: Soumya Ghosh Dastidar <44349253+gdsoumya@users.noreply.github.com> Co-authored-by: Xiaopeng Han <hanxiaop8@outlook.com> Co-authored-by: Anubhav Gupta <mail.anubhav06@gmail.com> Co-authored-by: Rafal <rafal@akuity.io> Co-authored-by: Yiwei Gong <imwithye@gmail.com> Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com> Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Bhavya Bhut <pbhavy4@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.