Merged
Conversation
The inclusion of the `user-scalable=no` value in the viewport meta tag prevented viewport scaling, disabling the ability to zoom the webpage. This most typically affects mobile devices, given the nature of the `<meta name="viewport">` tag. Removing the restriction allows a user to zoom in to see small and fine detail in the UI -- such as zooming in on particular areas of a home security camera streams or other images, inspecting detail in state and other graphs, and so on. For users with accessibility requirements, such as low vision conditions, being able to zoom the frontend means they can enlarge UI elements to suit them (MDN explains several accessibility concerns at https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name#Accessibility_concerns_with_viewport_scaling) This change has no effect on users that choose not to use it (for example, only those that engage zooming such as via pinch-to-zoom on mobile devices will see the change) -- the frontend remains the same otherwise. Elements of the frontend that do use pinch-to-zoom (e.g. the Map) continue to work as expected, with pinches on that screen area being captured by the map.
…ad commands (#7230) Co-authored-by: Zack Barett <zackbarett@hey.com> Co-authored-by: Bram Kragten <mail@bramkragten.nl>
* Replace sequence matcher with VS Code's score-based implementation * Remove everything not related to fuzzyScore and matchSubstring * Fix bug when filter length <= 3 * Add licensing and credit to Microsoft * Remove unnecessary character codes * Remove old sequence matcher, update tests, fix issue with not finding best score in list of words * Remove unnecessary sequence precheck, refactor client api to remove array * Fix issue with score sorting not implemented correctly and thus not actually sorting by score * Update src/common/string/filter/sequence-matching.ts Co-authored-by: Bram Kragten <mail@bramkragten.nl> * Remove unnecessary string return from fuzzy matcher. Clean up code * Remove globals from filter. Move sorting logic into matcher * Update function description, make score property optional. Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Zack Barett <zackbarett@hey.com>
Co-authored-by: Donnie <donniekarnsinsb@hotmail.com>
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io> Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
<ha-card>use<h1>for header (Make <ha-card> use <h1> for header #7373) @spacegaier