New "clickable" property for <ha-data-table>#7351
Merged
bramkragten merged 1 commit intohome-assistant:devfrom Oct 15, 2020
Merged
New "clickable" property for <ha-data-table>#7351bramkragten merged 1 commit intohome-assistant:devfrom
bramkragten merged 1 commit intohome-assistant:devfrom
Conversation
bramkragten
approved these changes
Oct 15, 2020
bramkragten
reviewed
Oct 15, 2020
|
|
||
| @property({ type: Boolean }) public selectable = false; | ||
|
|
||
| @property({ type: Boolean }) public clickable = false; |
Member
There was a problem hiding this comment.
Not sure about the name clickable, but don't really have a good alternative either.
Member
Author
There was a problem hiding this comment.
For me it makes sense since the event is also called @click and that is basically what the new property is logically tied to. Would be even nicer, if we could detect if that event callback is attached, but I did not find a way to do so.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
New property so that a
<ha-data-table>can be marked as clickable and therefore the pointer cursor is used.An additional future change could be to make that a per row settings, in case only specific rows should be clickable. Not sure if we will have such a use-case, so this MVP is without such support.
I verified varies points:
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: