Skip to content

Compact header#7369

Merged
bramkragten merged 40 commits intohome-assistant:devfrom
maykar:custom-header
Oct 21, 2020
Merged

Compact header#7369
bramkragten merged 40 commits intohome-assistant:devfrom
maykar:custom-header

Conversation

@maykar
Copy link
Contributor

@maykar maykar commented Oct 17, 2020

Proposed change

This compacts the header to combine both buttons and tabs. Additionally, this modifies views so their backgrounds extend behind the header in Lovelace. When using a transparent color or image for the header background the view's background will now show underneath.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

compactheader


@ 320px wide

image

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@maykar maykar changed the title Custom header Compact header Oct 17, 2020
@zsarnett
Copy link
Contributor

ITS FINALLY HAPPENING 🎉 🎉 🎉 🎉

@balloob
Copy link
Member

balloob commented Oct 17, 2020

How will this work when the user has more tabs that fit the view? If you have found a solution for that that works, there would no need to be an option and we can always do it.

@maykar
Copy link
Contributor Author

maykar commented Oct 17, 2020

My previous PR added adjustments to paper-tabs in order to make scrolling work in such a way that the scroll buttons no longer take up extra space. So the tabs would fill the space between the buttons and still be scrollable without extra padding given to a hidden scroll arrow.

@maykar maykar marked this pull request as draft October 17, 2020 11:28
@maykar maykar marked this pull request as ready for review October 17, 2020 11:57
@MrJelly17

This comment has been minimized.

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
@TheDK

This comment has been minimized.

@poldim
Copy link

poldim commented Oct 21, 2020

@maykar will this make the header by default compact on all views from all devices? Or will it just now allow it to be adjusted via themes but default to non-compact style?

@bramkragten
Copy link
Member

@maykar will this make the header by default compact on all views from all devices? Or will it just now allow it to be adjusted via themes but default to non-compact style?

It will compact all Lovelace headers

@RssFra97

This comment has been minimized.

@home-assistant home-assistant locked and limited conversation to collaborators Oct 22, 2020
@bramkragten
Copy link
Member

Please don't react to closed PR's

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants