Add help link on automations picker and updated links for scripts and scenes#7129
Add help link on automations picker and updated links for scripts and scenes#7129zsarnett merged 2 commits intohome-assistant:devfrom
Conversation
| <ha-icon-button | ||
| slot="toolbar-icon" | ||
| icon="hass:help-circle" | ||
| @click=${this._showHelp} | ||
| ></ha-icon-button> |
There was a problem hiding this comment.
| <ha-icon-button | |
| slot="toolbar-icon" | |
| icon="hass:help-circle" | |
| @click=${this._showHelp} | |
| ></ha-icon-button> | |
| <mwc-icon-button @click=${this._showHelp}> | |
| <ha-svg-button | |
| slot="toolbar-icon" | |
| .path=${mdiHelpCircle} | |
| ></ha-svg-button> | |
| </mwc-icon-button> |
This formatting is probably not perfect
There was a problem hiding this comment.
I pulled that code from both the scripts picker and the scenes picker. Are you saying both need to be updated?
There was a problem hiding this comment.
Yes. We recently moved to use this method with the new MDI/JS library
There was a problem hiding this comment.
I'm happy to change all of them, I just want to confirm that's what needs to be done
There was a problem hiding this comment.
Hmm. That change makes the icons disappear. I'm getting an error in the console
DevTools failed to load SourceMap: Could not parse content for http://10.1.1.4:8124/config/scene/mdc.circular-progress.min.css.map: Unexpected token < in JSON at position 0
There was a problem hiding this comment.
That error has nothing to do with that, it will show anytime a circular progress is used. Make sure to import the correct elements
There was a problem hiding this comment.
Sorry :/ I can't get the icon to show up again. I think I have all the imports it needs and I'm not seeing any errors. I'll try again tomorrow I suppose
There was a problem hiding this comment.
I fucked the comment up
its supposed to ha-svg-icon
There was a problem hiding this comment.
Ah yup, that was part of it. Thanks for catching that! The other thing appears to be slot needing to be in mwc-icon-button instead of inside ha-svg-icon
|
Got a screen shot? |
|
|
|
I'll rebase in the morning and get some screenshots to verify the changes |
Villhellm
force-pushed
the
help-links
branch
from
f01160f to
2028676
Compare
Villhellm
changed the title
|
|
| import { DataTableColumnContainer } from "../../../components/data-table/ha-data-table"; | ||
| import { showAlertDialog } from "../../../dialogs/generic/show-dialog-box"; | ||
| import "../../../components/entity/ha-entity-toggle"; | ||
| import "../../../components/ha-icon-button"; |
4 participants
Breaking change
Proposed change
Add a help link to the automation picker panel. Scripts and scenes have this link already. Just trying to make the panel a little more consistent.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: