Skip to content

Fixed localization of relative time#7256

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
kukulich:relative-time
Oct 8, 2020
Merged

Fixed localization of relative time#7256
bramkragten merged 1 commit intohome-assistant:devfrom
kukulich:relative-time

Conversation

@kukulich
Copy link
Contributor

@kukulich kukulich commented Oct 7, 2020

Breaking change

Proposed change

It's currently not possible to translate relative time strings right. It does not work in some languages.

In English:

  • 1 minute
  • 1 minute ago
  • In 1 minute

One word "minute"

The same in Czech:

  • 1 minuta
  • Před 1 minutou
  • Za 1 minutu

Three words: "minuta", "minutou", "minutu"

So it's neccessary to translate it as a whole to have the right context.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit b877753 into home-assistant:dev Oct 8, 2020
@kukulich
Copy link
Contributor Author

kukulich commented Oct 8, 2020

Thanks!

@bramkragten bramkragten mentioned this pull request Oct 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants