Skip to content

Add Counter to Helpers#7346

Merged
bramkragten merged 3 commits intohome-assistant:devfrom
danimart1991:counterHelper
Oct 17, 2020
Merged

Add Counter to Helpers#7346
bramkragten merged 3 commits intohome-assistant:devfrom
danimart1991:counterHelper

Conversation

@danimart1991
Copy link
Contributor

@danimart1991 danimart1991 commented Oct 14, 2020

Proposed change

Add Counter to Helpers UI.

image

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

counter:

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@danimart1991
Copy link
Contributor Author

I'm currently working on this. A few questions:

  • I have problems saving the value of the restore bool value while using a Switch. Maybe I forgot something or I'm using the wrong component?
  • Actually default_config component doesn't include Counter so I think is necessary an extra step to include it.

@bramkragten
Copy link
Member

Yes, counter should be added to default_config in the core repo.

@danimart1991 danimart1991 marked this pull request as ready for review October 15, 2020 21:57
@bramkragten bramkragten merged commit cbef909 into home-assistant:dev Oct 17, 2020
@danimart1991 danimart1991 deleted the counterHelper branch October 17, 2020 20:33
@bramkragten bramkragten mentioned this pull request Oct 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add counter to the helper UI

3 participants