Skip to content

Added entity_id to history graph tooltip#7310

Merged
bramkragten merged 4 commits intohome-assistant:devfrom
tobias-kuendig:entity-id-history-tooltip
Oct 12, 2020
Merged

Added entity_id to history graph tooltip#7310
bramkragten merged 4 commits intohome-assistant:devfrom
tobias-kuendig:entity-id-history-tooltip

Conversation

@tobias-kuendig
Copy link
Contributor

Proposed change

For this year's Hacktoberfest I wanted to finally deep-dive into my favourite open-source project of this year! This is just a minor addition but something that has irked me for a few weeks now.

This PR adds the entity_id as a beforeBody text to the timeline history graph tooltip.

ha

If there are entities with the same name (like a group + light or a device_tracker + person), this change makes it easy to identify what data you are looking at.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New (minor!) feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

This PR makes the Chart.js beforeBody property usable in chart tooltips. The property is documented here: https://www.chartjs.org/docs/latest/configuration/tooltip.html

@homeassistant
Copy link
Contributor

Hi @tobias-kuendig,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@bramkragten
Copy link
Member

We should only show the entity_id when in advanced mode

@tobias-kuendig
Copy link
Contributor Author

Good point, I have update this PR.

Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@bramkragten bramkragten merged commit 993d73c into home-assistant:dev Oct 12, 2020
@bramkragten bramkragten mentioned this pull request Oct 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants