Added entity_id to history graph tooltip#7310
Merged
bramkragten merged 4 commits intohome-assistant:devfrom Oct 12, 2020
tobias-kuendig:entity-id-history-tooltip
Merged
Added entity_id to history graph tooltip#7310bramkragten merged 4 commits intohome-assistant:devfrom tobias-kuendig:entity-id-history-tooltip
bramkragten merged 4 commits intohome-assistant:devfrom
tobias-kuendig:entity-id-history-tooltip
Conversation
Contributor
|
Hi @tobias-kuendig, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Member
|
We should only show the |
Contributor
Author
|
Good point, I have update this PR. |
bramkragten
reviewed
Oct 12, 2020
bramkragten
reviewed
Oct 12, 2020
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
bramkragten
approved these changes
Oct 12, 2020
Merged
3 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
For this year's Hacktoberfest I wanted to finally deep-dive into my favourite open-source project of this year! This is just a minor addition but something that has irked me for a few weeks now.
This PR adds the entity_id as a
beforeBodytext to the timeline history graph tooltip.If there are entities with the same name (like a group + light or a device_tracker + person), this change makes it easy to identify what data you are looking at.
Type of change
Additional information
This PR makes the Chart.js
beforeBodyproperty usable in chart tooltips. The property is documented here: https://www.chartjs.org/docs/latest/configuration/tooltip.html