Skip to content

Weather Card: add icons instead of text#7305

Merged
zsarnett merged 4 commits intodevfrom
weather-icons
Oct 12, 2020
Merged

Weather Card: add icons instead of text#7305
zsarnett merged 4 commits intodevfrom
weather-icons

Conversation

@zsarnett
Copy link
Contributor

Proposed change

image

Type of change

  • New feature (thank you!)

Example configuration

- attribute: humidity
  entity: weather.dark_sky
  name: Home
  show_forecast: true
  type: weather-forecast
- entity: weather.home
  show_forecast: false
  type: weather-forecast
- entity: weather.dark_sky
  name: 'Chicago, Illinois'
  show_forecast: false
  type: weather-forecast
  secondary_info_attribute: wind_speed
- entity: weather.openweathermap
  name: Open Weather Map
  type: weather-forecast
- entity: weather.dark_sky
  name: 'Chicago, Illinois'
  show_forecast: false
  type: weather-forecast
  secondary_info_attribute: visibility
- entity: weather.dark_sky
  name: 'Chicago, Illinois'
  show_forecast: false
  type: weather-forecast
  secondary_info_attribute: pressure

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@zsarnett zsarnett changed the title add icons instead of text Weather Card: add icons instead of text Oct 11, 2020
></ha-svg-icon>
`
: this.hass!.localize(
`ui.card.weather.attributes.${this._config.secondary_info_attribute}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still use the other translations elsewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the More info

zsarnett and others added 2 commits October 12, 2020 10:32
@zsarnett zsarnett merged commit 02e4e3c into dev Oct 12, 2020
@zsarnett zsarnett deleted the weather-icons branch October 12, 2020 16:52
@bramkragten bramkragten mentioned this pull request Oct 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants