Skip to content

Prevent old more info control to be created#7324

Merged
bramkragten merged 2 commits intodevfrom
prevent-creation-old-more-info
Oct 17, 2020
Merged

Prevent old more info control to be created#7324
bramkragten merged 2 commits intodevfrom
prevent-creation-old-more-info

Conversation

@bramkragten
Copy link
Member

Proposed change

Because the more info control tag would be set in updated, we would first load the previous more info dialog control. Moved it to showDialog, as that is the only moment the entity id will change.

Alternative would be to set _moreInfoType to undefined in closeDialog/showDialog.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 5740b01 into dev Oct 17, 2020
@bramkragten bramkragten deleted the prevent-creation-old-more-info branch October 17, 2020 20:04
@bramkragten bramkragten mentioned this pull request Oct 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants