Fix tab focus issue in entity picker and password form.#7252
Merged
bramkragten merged 2 commits intohome-assistant:devfrom Oct 8, 2020
maykar:tab-focus-fix
Merged
Fix tab focus issue in entity picker and password form.#7252bramkragten merged 2 commits intohome-assistant:devfrom maykar:tab-focus-fix
bramkragten merged 2 commits intohome-assistant:devfrom
maykar:tab-focus-fix
Conversation
bramkragten
approved these changes
Oct 8, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This sets the
tab-indexof button elements insidepaper-inputsto-1. This fixes the issue of the tab key not moving on to the next element as it should. Since you can press down to show entities and delete the contents via keyboard it would be unnecessary to be able to tab to those button elements for accessibility. This also setstab-index="-1"for the password field's unmask button to fix the same issue on login form.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: