Skip to content

Fix tab focus issue in entity picker and password form.#7252

Merged
bramkragten merged 2 commits intohome-assistant:devfrom
maykar:tab-focus-fix
Oct 8, 2020
Merged

Fix tab focus issue in entity picker and password form.#7252
bramkragten merged 2 commits intohome-assistant:devfrom
maykar:tab-focus-fix

Conversation

@maykar
Copy link
Contributor

@maykar maykar commented Oct 7, 2020

Proposed change

This sets the tab-index of button elements inside paper-inputs to -1. This fixes the issue of the tab key not moving on to the next element as it should. Since you can press down to show entities and delete the contents via keyboard it would be unnecessary to be able to tab to those button elements for accessibility. This also sets tab-index="-1" for the password field's unmask button to fix the same issue on login form.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@maykar maykar changed the title Fix tab focus issue in entity picker. Fix tab focus issue in entity picker and password form. Oct 7, 2020
@bramkragten bramkragten merged commit 701bea6 into home-assistant:dev Oct 8, 2020
@bramkragten bramkragten mentioned this pull request Oct 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

3 participants