Entity registry settings: Remove "Override" string + use domain icon as fallback

[spacegaier]

Breaking change

Proposed change

As outlined in the linked issue: Make it clearer what we are overriding:

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes Change "Name Override" to "Friendly Name Override" for clarity #4610
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

[zsarnett]

We should drop the friendly part everywhere and just show name.

[zsarnett]

Keep the backend the same but frontend should be Name

[spacegaier]

Then it looks interesting, since the attribute is still named differently, but since that's in dev tools, I think we can ignore that.

I searched a bit, but I cannot find any place in the UI where we actually show "friendly". Am I missing something?

[spacegaier]

One thing I just realized is that the inputs for name and icon behave differently. The name always shows the input label (e.g. Name Override) above the input area, where as the icon input uses the input label as long as there is no value for the input.

Should we have two components that behave the same in that regard?

@zsarnett In your opinion, the fields should just be named "Name" and "Icon" without the "Override" or did I get you wrong?

[bramkragten]

They do behave the same

But if there is no placeholder the label will take that place when not active. There will only be a placeholder when the entity registry has an icon, we could maybe use the domain default as a fallback...

[zsarnett]

Yes I do think we should drop the Override

[spacegaier]

@bramkragten @zsarnett I incorporated both your proposals.