Skip to content

use ha-svg-icon in more-info-weather#7196

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
Misiu:move_icons
Oct 2, 2020
Merged

use ha-svg-icon in more-info-weather#7196
bramkragten merged 1 commit intohome-assistant:devfrom
Misiu:move_icons

Conversation

@Misiu
Copy link
Copy Markdown
Contributor

@Misiu Misiu commented Oct 2, 2020

Breaking change

Proposed change

First PR to replace ha-icon with ha-svg-icon.
If it gets approved I'll work on other places.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Copy Markdown
Member

@bramkragten bramkragten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bramkragten bramkragten merged commit 72aa9a3 into home-assistant:dev Oct 2, 2020
@bramkragten bramkragten mentioned this pull request Oct 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants