Merged
Conversation
zsarnett
reviewed
Oct 12, 2020
|
|
||
| <script type="module" crossorigin="use-credentials"> | ||
| import "<%= latestPageJS %>"; | ||
| <script crossorigin="use-credentials"> |
Member
Author
There was a problem hiding this comment.
Nope that's all in this one
balloob
reviewed
Oct 12, 2020
| // Only support the syntax, Webpack will handle it. | ||
| "@babel/plugin-syntax-import-meta", | ||
| "@babel/syntax-dynamic-import", | ||
| "@babel/plugin-syntax-dynamic-import", |
Member
There was a problem hiding this comment.
We used to only load syntax because webpack dealt with the processing. What do we gain from adding this?
Member
Author
There was a problem hiding this comment.
Wasn't this just a typo?
Member
Author
There was a problem hiding this comment.
This is still the plugin for the syntax
balloob
reviewed
Oct 12, 2020
balloob
reviewed
Oct 12, 2020
balloob
approved these changes
Oct 12, 2020
balloob
reviewed
Oct 13, 2020
build-scripts/webpack.js
Outdated
| rules: [ | ||
| { | ||
| test: /\.js$|\.ts$/, | ||
| test: /\..?js$|\.ts$/, |
Member
There was a problem hiding this comment.
Let's make the m more explicit. Think that this should work?
Suggested change
| test: /\..?js$|\.ts$/, | |
| test: /\.m?js$|\.ts$/, |
Member
Author
There was a problem hiding this comment.
Yeah, made it a point so it would also pick up cjs and I don't know what other types of js files are out there.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Fixes our ES5 build
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: